Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml to all libraries #10528

Open
plamut opened this issue Jan 13, 2021 · 2 comments
Open

Add pyproject.toml to all libraries #10528

plamut opened this issue Jan 13, 2021 · 2 comments
Assignees
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@plamut
Copy link
Contributor

plamut commented Jan 13, 2021

We should add a pyproject.toml file to all libraries to explicitly specify what build tools they need. At the time of writing, the implicit default assumed by pip is setuptools, but we can make this explicit with pyproject.toml.

As per blog post linked below, if a project uses setuptools, the contents of pyproject.toml should be the following (which is what pip currently assumes if that file is missing):

[build-system]
requires = ["setuptools >= 40.6.0", "wheel"]
build-backend = "setuptools.build_meta"

Resources:

  • PEP 518 - defines a standard way for the libraries to define their build system dependencies (in the abovementioned pyproject.toml file).
  • PEP 517 - defines how build tools should be executed for a project that provides pyproject.toml.
  • Blog post by one of the CPython core developers explaining all this in plain English. 🙂
@plamut plamut added the type: process A process-related concern. May include testing, release, or the like. label Jan 13, 2021
@jamierpond
Copy link

@plamut any news on this?

@plamut
Copy link
Contributor Author

plamut commented Dec 19, 2022

@jamierpond I no longer maintain these libraries, thus cannot really say, sorry.

@busunkim96 Do you perhaps know, if this has been considered yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

3 participants