From 238f3a20dbb70545ad9b446c379f5567af8b8501 Mon Sep 17 00:00:00 2001 From: Yoshi Automation Bot Date: Wed, 5 Jun 2019 10:04:39 -0700 Subject: [PATCH] feat: support apiEndpoint override in client constructor (#180) --- .../google-cloud-redis/src/v1/cloud_redis_client.js | 1 + .../src/v1beta1/cloud_redis_client.js | 1 + packages/google-cloud-redis/synth.metadata | 10 +++++----- packages/google-cloud-redis/test/gapic-v1.js | 5 +++++ packages/google-cloud-redis/test/gapic-v1beta1.js | 5 +++++ 5 files changed, 17 insertions(+), 5 deletions(-) diff --git a/packages/google-cloud-redis/src/v1/cloud_redis_client.js b/packages/google-cloud-redis/src/v1/cloud_redis_client.js index 4f78f2e5d1f..8d9d3803bbb 100644 --- a/packages/google-cloud-redis/src/v1/cloud_redis_client.js +++ b/packages/google-cloud-redis/src/v1/cloud_redis_client.js @@ -70,6 +70,7 @@ class CloudRedisClient { * API remote host. */ constructor(opts) { + opts = opts || {}; this._descriptors = {}; const servicePath = diff --git a/packages/google-cloud-redis/src/v1beta1/cloud_redis_client.js b/packages/google-cloud-redis/src/v1beta1/cloud_redis_client.js index 2e1934fed54..95a39c222e2 100644 --- a/packages/google-cloud-redis/src/v1beta1/cloud_redis_client.js +++ b/packages/google-cloud-redis/src/v1beta1/cloud_redis_client.js @@ -70,6 +70,7 @@ class CloudRedisClient { * API remote host. */ constructor(opts) { + opts = opts || {}; this._descriptors = {}; const servicePath = diff --git a/packages/google-cloud-redis/synth.metadata b/packages/google-cloud-redis/synth.metadata index 54e115af194..a2d77bc80bc 100644 --- a/packages/google-cloud-redis/synth.metadata +++ b/packages/google-cloud-redis/synth.metadata @@ -1,19 +1,19 @@ { - "updateTime": "2019-06-04T19:40:52.868638Z", + "updateTime": "2019-06-05T11:12:08.959832Z", "sources": [ { "generator": { "name": "artman", - "version": "0.23.0", - "dockerImage": "googleapis/artman@sha256:846102ebf7ea2239162deea69f64940443b4147f7c2e68d64b332416f74211ba" + "version": "0.23.1", + "dockerImage": "googleapis/artman@sha256:9d5cae1454da64ac3a87028f8ef486b04889e351c83bb95e83b8fab3959faed0" } }, { "git": { "name": "googleapis", "remote": "https://github.com/googleapis/googleapis.git", - "sha": "0026f4b890ed9e2388fb0573c0727defa6f5b82e", - "internalRef": "251265049" + "sha": "4f3516a6f96dac182973a3573ff5117e8e4f76c7", + "internalRef": "251559960" } }, { diff --git a/packages/google-cloud-redis/test/gapic-v1.js b/packages/google-cloud-redis/test/gapic-v1.js index c0d7883aae9..0a37c762379 100644 --- a/packages/google-cloud-redis/test/gapic-v1.js +++ b/packages/google-cloud-redis/test/gapic-v1.js @@ -39,6 +39,11 @@ describe('CloudRedisClient', () => { assert(typeof port === 'number'); }); + it('should create a client with no options', () => { + const client = new redisModule.v1.CloudRedisClient(); + assert(client); + }); + describe('listInstances', () => { it('invokes listInstances without error', done => { const client = new redisModule.v1.CloudRedisClient({ diff --git a/packages/google-cloud-redis/test/gapic-v1beta1.js b/packages/google-cloud-redis/test/gapic-v1beta1.js index 9188e298950..31916576f8e 100644 --- a/packages/google-cloud-redis/test/gapic-v1beta1.js +++ b/packages/google-cloud-redis/test/gapic-v1beta1.js @@ -39,6 +39,11 @@ describe('CloudRedisClient', () => { assert(typeof port === 'number'); }); + it('should create a client with no options', () => { + const client = new redisModule.v1beta1.CloudRedisClient(); + assert(client); + }); + describe('listInstances', () => { it('invokes listInstances without error', done => { const client = new redisModule.v1beta1.CloudRedisClient({