Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: TestIntegration_PredefinedACLs failed #8511

Closed
flaky-bot bot opened this issue Aug 30, 2023 · 4 comments
Closed

storage: TestIntegration_PredefinedACLs failed #8511

flaky-bot bot opened this issue Aug 30, 2023 · 4 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Aug 30, 2023

Note: #7653 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: fbfaf21
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:4028: Object.ACL: expected acl to contain: {entity:allAuthenticatedUsers role:READER}, got acl: [{Entity:allUsers EntityID: Role:READER Domain: Email: ProjectTeam:} {Entity:user-kokoro@dulcet-port-762.iam.gserviceaccount.com EntityID: Role:OWNER Domain: Email:kokoro@dulcet-port-762.iam.gserviceaccount.com ProjectTeam:}]
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 30, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 30, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Aug 30, 2023

Test passed for commit 05a1484 (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Aug 30, 2023
@flaky-bot flaky-bot bot reopened this Aug 31, 2023
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Aug 31, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Aug 31, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


commit: 1a928ae
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:4028: Object.ACL: expected acl to contain: {entity:allAuthenticatedUsers role:READER}, got acl: [{Entity:allUsers EntityID: Role:READER Domain: Email: ProjectTeam:} {Entity:user-kokoro@dulcet-port-762.iam.gserviceaccount.com EntityID: Role:OWNER Domain: Email:kokoro@dulcet-port-762.iam.gserviceaccount.com ProjectTeam:}]

@tritone tritone added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Sep 11, 2023
@BrennaEpp
Copy link
Contributor

This is for the second Object.ACL check in the test (currently L4370). It's already wrapped in a retry loop; this needs some investigation.

@tritone tritone assigned BrennaEpp and unassigned tritone Feb 6, 2024
@BrennaEpp
Copy link
Contributor

BrennaEpp commented Feb 8, 2024

So the object is created with w.PredefinedACL = "authenticatedRead" set. It seems that instead of allAuthenticatedUsers , allUsers was set in the acl. The retry loop seems fine.

This seems unlikely to be an issue in the client library. Since this is quite old, I will close this for now, will see if it comes up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants