-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: How to use custom domain but with pathstyle in URL signer options? #3866
Comments
I looked into this and I think you're correct that this use case is supported in the GCS API; however it's not currently supported by the Go SDK. I'm following up internally to see if there's a reason why we decided not to support this while building this feature. Can you speak a little more to your use case here? I think our assumption was that most users would use bucketBoundHostname for CNAMEs (or other hosts that would map to a single bucket). |
Since this is not currently supported in the library, I'm going to leave this open but change it to a feature request. |
@tritone Sorry for a very late reply. But if I recall correctly, we had constraints around using bucket names as sub domains. It's a big project and we primarily use sub domains for differentiating between customers/deployments. I think wild cards were a bit of a problem. |
Thanks for filing this issue! This was done in #8113. It should be in the next release: storage 1.31.0 With this release, you should be able to set |
In URLStyle(for signing options), there are three styles implemented currently bucketBoundHostname, pathStyle, virtualHostedStyle. I need to use custom domain but with path style bucket convention.
I tried to implement URLStyle interface, but its methods are private.
My assumption is that signed urls work no matter what the hostname is as long as the signing is done with the same host name. So it should be fundamentally legal.
How to achieve this using go SDK?
Example:
https://customdomain.com/bucket/key?signature....&other params
The text was updated successfully, but these errors were encountered: