diff --git a/google/cloud/internal/compute_engine_util.cc b/google/cloud/internal/compute_engine_util.cc index 22bdc2512ebec..917c520b5e6df 100644 --- a/google/cloud/internal/compute_engine_util.cc +++ b/google/cloud/internal/compute_engine_util.cc @@ -25,7 +25,7 @@ std::string GceMetadataScheme() { return "http"; } std::string GceMetadataHostname() { return google::cloud::internal::GetEnv(GceMetadataHostnameEnvVar()) - .value_or("metadata.google.internal"); + .value_or("metadata.google.internal."); } } // namespace internal diff --git a/google/cloud/internal/compute_engine_util_test.cc b/google/cloud/internal/compute_engine_util_test.cc index da9994cf220e3..1adff2755506e 100644 --- a/google/cloud/internal/compute_engine_util_test.cc +++ b/google/cloud/internal/compute_engine_util_test.cc @@ -33,7 +33,7 @@ TEST(ComputeEngineUtilTest, CanOverrideGceMetadataHostname) { // If not overridden for testing, we should get the actual hostname. google::cloud::testing_util::ScopedEnvironment gce_metadata_hostname_unset( GceMetadataHostnameEnvVar(), {}); - EXPECT_EQ(std::string("metadata.google.internal"), GceMetadataHostname()); + EXPECT_EQ(std::string("metadata.google.internal."), GceMetadataHostname()); } } // namespace diff --git a/google/cloud/internal/unified_rest_credentials_test.cc b/google/cloud/internal/unified_rest_credentials_test.cc index 86a76db349377..bb1ed165b5784 100644 --- a/google/cloud/internal/unified_rest_credentials_test.cc +++ b/google/cloud/internal/unified_rest_credentials_test.cc @@ -236,7 +236,7 @@ TEST(UnifiedRestCredentialsTest, AdcIsComputeEngine) { auto client = std::make_unique(); auto expected_request = AllOf( Property(&RestRequest::path, - absl::StrCat("http://metadata.google.internal/", + absl::StrCat("http://metadata.google.internal./", "computeMetadata/v1/instance/service-accounts/", "default/")), Property(&RestRequest::headers, @@ -250,7 +250,7 @@ TEST(UnifiedRestCredentialsTest, AdcIsComputeEngine) { auto client = std::make_unique(); auto expected_request = AllOf( Property(&RestRequest::path, - absl::StrCat("http://metadata.google.internal/", + absl::StrCat("http://metadata.google.internal./", "computeMetadata/v1/instance/service-accounts/", "default/", "token")), Property(&RestRequest::headers, diff --git a/google/cloud/storage/internal/compute_engine_util.cc b/google/cloud/storage/internal/compute_engine_util.cc index b42d27a8d2229..2228349920ed8 100644 --- a/google/cloud/storage/internal/compute_engine_util.cc +++ b/google/cloud/storage/internal/compute_engine_util.cc @@ -24,7 +24,7 @@ namespace internal { std::string GceMetadataHostname() { return google::cloud::internal::GetEnv(GceMetadataHostnameEnvVar()) - .value_or("metadata.google.internal"); + .value_or("metadata.google.internal."); } } // namespace internal diff --git a/google/cloud/storage/internal/compute_engine_util_test.cc b/google/cloud/storage/internal/compute_engine_util_test.cc index 124c0c62cd7b9..2baa1d0e24646 100644 --- a/google/cloud/storage/internal/compute_engine_util_test.cc +++ b/google/cloud/storage/internal/compute_engine_util_test.cc @@ -41,7 +41,7 @@ TEST_F(ComputeEngineUtilTest, CanOverrideGceMetadataHostname) { // If not overridden for testing, we should get the actual hostname. google::cloud::testing_util::ScopedEnvironment gce_metadata_hostname_unset( GceMetadataHostnameEnvVar(), {}); - EXPECT_EQ(std::string("metadata.google.internal"), GceMetadataHostname()); + EXPECT_EQ(std::string("metadata.google.internal."), GceMetadataHostname()); } } // namespace