Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire CurlClient transport implementation for GCS #9659

Closed
scotthart opened this issue Aug 8, 2022 · 4 comments · Fixed by #12828
Closed

Retire CurlClient transport implementation for GCS #9659

scotthart opened this issue Aug 8, 2022 · 4 comments · Fixed by #12828
Assignees
@coryan @scotthart
Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@scotthart
Copy link
Member

Add option to GCS to choose between new internal rest library or legacy implementation for http transport, defaulting to new rest library. Legacy implementation option will remain available for 3 months after switchover as an escape hatch.
@scotthart scotthart added api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern. labels Aug 8, 2022
@scotthart scotthart self-assigned this Aug 8, 2022
@scotthart
Copy link
Member Author

GCS Transport Benchmark_ Legacy vs RestLib.pdf

@scotthart scotthart mentioned this issue Aug 11, 2022
Merged
@coryan
Copy link
Contributor

coryan commented Jan 11, 2023

We still need to see more usage to switch.

@coryan coryan changed the title Make RestClient default http transport implementation for GCS Retire CurlClient transport implementation for GCS Jan 11, 2023
@coryan
Copy link
Contributor

coryan commented May 3, 2023

We are still waiting for usage to go down.

@coryan
Copy link
Contributor

coryan commented Aug 30, 2023

We are expecting to close this around 2023-10-01.

This was referenced Oct 4, 2023
Merged
Merged
Merged
Merged
Merged
@coryan coryan self-assigned this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

@scotthart scotthart

Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup(storage): remove Curl* implementations coryan/google-cloud-cpp
2 participants
@coryan @scotthart