Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cap the number of ack ids when extending leases #9471

Closed
coryan opened this issue Jul 13, 2022 · 0 comments · Fixed by #10032
Closed

Cap the number of ack ids when extending leases #9471

coryan opened this issue Jul 13, 2022 · 0 comments · Fixed by #10032
Assignees
@coryan
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@coryan
Copy link
Contributor

coryan commented Jul 13, 2022

Pub/Sub has limits on the message size and consequently on the number of ack ids in a single message. We should never send more than 2,500 ack ids in a single request.
@coryan coryan added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. api: pubsub Issues related to the Pub/Sub API. labels Jul 13, 2022
@coryan coryan self-assigned this Oct 11, 2022
@coryan coryan mentioned this issue Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
api: pubsub Issues related to the Pub/Sub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pubsub): limit ModifyAckDeadlineRequest size coryan/google-cloud-cpp
1 participant
@coryan