Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -DGOOGLE_CLOUD_CPP_GOOGLEAPIS_PROVIDER=external from the windows build #2895

Closed
tmatsuo opened this issue Jul 18, 2019 · 1 comment · Fixed by #2962
Closed

Remove -DGOOGLE_CLOUD_CPP_GOOGLEAPIS_PROVIDER=external from the windows build #2895

tmatsuo opened this issue Jul 18, 2019 · 1 comment · Fixed by #2962
Assignees
@coryan
Labels
testing type: cleanup An internal cleanup or hygiene concern.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented Jul 18, 2019

Context #2888

Once we have vcpkg package for googleapis.
@tmatsuo tmatsuo mentioned this issue Jul 18, 2019
Merged
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 19, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jul 29, 2019
@coryan coryan added type: cleanup An internal cleanup or hygiene concern. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jul 30, 2019
@ghost
Copy link

ghost commented Aug 9, 2019

This can be done now. microsoft/vcpkg#7557 is merged.

@coryan coryan self-assigned this Aug 12, 2019
@coryan coryan mentioned this issue Aug 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
testing type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup: Use vcpkg for all dependencies in Windows build. coryan/google-cloud-cpp
3 participants
@tmatsuo @coryan @yoshi-automation