Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl callbacks reading from rest_internal::WriteVector when no more data is present #14614

Closed
scotthart opened this issue Aug 5, 2024 · 0 comments · Fixed by #14615
Closed

curl callbacks reading from rest_internal::WriteVector when no more data is present #14614

scotthart opened this issue Aug 5, 2024 · 0 comments · Fixed by #14615
Assignees
@scotthart
Labels
cpp: rest priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@scotthart
Copy link
Member

google-cloud-cpp/google/cloud/internal/curl_writev.cc

Line 36 in 36c3aee

std::copy(src.begin(), src.begin() + dst.size(), dst.begin());
leads to a crash when no data is left
@scotthart scotthart added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. cpp: rest labels Aug 5, 2024
@scotthart scotthart self-assigned this Aug 5, 2024
@scotthart scotthart mentioned this issue Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scotthart scotthart

Labels
cpp: rest priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rest): prevent libcurl callback from reading bad address scotthart/google-cloud-cpp
1 participant
@scotthart