Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential crash in PooledCurlHandleFactory #14132

Closed
coryan opened this issue May 6, 2024 · 0 comments · Fixed by #14134
Closed

Potential crash in PooledCurlHandleFactory #14132

coryan opened this issue May 6, 2024 · 0 comments · Fixed by #14134
Assignees
Labels
api: storage Issues related to the Cloud Storage API. cpp: rest priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@coryan
Copy link
Contributor

coryan commented May 6, 2024

Reported anonymously. This:

auto const release_count =
(std::min)(handles_.size() - maximum_size_ / 2,
active_multi_handles_ - maximum_size_);

should be:

    auto const release_count =
        (std::min)(multi_handles_.size() - maximum_size_ / 2,
                   active_multi_handles_ - maximum_size_);

Notes the change from handles_ to multi_handles_ on line 183.

@coryan coryan added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 6, 2024
@coryan coryan self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cpp: rest priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant