Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor QuotaUserOption to common options #13928

Closed
coryan opened this issue Apr 5, 2024 · 0 comments · Fixed by #13933
Closed

Refactor QuotaUserOption to common options #13928

coryan opened this issue Apr 5, 2024 · 0 comments · Fixed by #13933
Assignees
@coryan
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Contributor

coryan commented Apr 5, 2024

Currently this lives in rest_internal:

google-cloud-cpp/google/cloud/rest_options.h

Lines 39 to 41 in 5adda4a

struct QuotaUserOption {
using Type = std::string;
};

But it can be used with gRPC using the x-goog-quota-user header.
@coryan coryan added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 5, 2024
@coryan coryan self-assigned this Apr 5, 2024
This was referenced Apr 5, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(common): QuotaUserOption for gRPC-based libs coryan/google-cloud-cpp
1 participant
@coryan