Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnect async traces with backoffs #13141

Closed
dbolduc opened this issue Nov 16, 2023 · 0 comments · Fixed by #13147
Closed

Reconnect async traces with backoffs #13141

dbolduc opened this issue Nov 16, 2023 · 0 comments · Fixed by #13147
Assignees
@dbolduc
Labels
cpp: opentelemetry priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@dbolduc
Copy link
Member

dbolduc commented Nov 16, 2023 •
edited
Loading

I introduced a new bug in the implementation of #12880. I thought I was being helpful by having EndSpan(..., future<T>) detach the current context. Well, if we don't attach a context for the operation first, we run into problems. This happens in TracedAsyncBackoff().

We currently get broken traces like:
image

We want traces like:
image

Aside: more evidence that we could use something like #13034
@dbolduc dbolduc added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. cpp: opentelemetry labels Nov 16, 2023
@dbolduc dbolduc self-assigned this Nov 16, 2023
This was referenced Nov 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbolduc dbolduc

Labels
cpp: opentelemetry priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(otel): reconnect async traces (e.g. LROs) dbolduc/google-cloud-cpp
1 participant
@dbolduc