Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Pub/Sub admin API keeping handwritten version only for backwards compatibility #12873

Closed
alevenberg opened this issue Oct 11, 2023 · 4 comments
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@alevenberg
Copy link
Member

alevenberg commented Oct 11, 2023

Design in: go/cloud-cxx:pub-sub-admin-apis

@alevenberg alevenberg added the type: cleanup An internal cleanup or hygiene concern. label Oct 11, 2023
@alevenberg alevenberg self-assigned this Oct 11, 2023
@coryan
Copy link
Contributor

coryan commented Oct 11, 2023

Maybe start with "Generate Pub/Sub admin API keeping handwritten version only for backwards compatibility"?

@alevenberg alevenberg changed the title Replace the handwritten pub/sub admin API with the generated API Generate Pub/Sub admin API keeping handwritten version only for backwards compatibility Oct 11, 2023
@alevenberg alevenberg changed the title Generate Pub/Sub admin API keeping handwritten version only for backwards compatibility Separate Pub/Sub Admin Client Oct 11, 2023
@alevenberg
Copy link
Member Author

Getting a weird stack trace when I run the generator with omit_client = false for pub sub. Will investigate later but for reference:

google/cloud/retail/v2/user_event_service.proto:23:1: warning: Import google/api/resource.proto is unused.
*** Check failure stack trace: ***
    @           0xb94bc1  absl::lts_20230802::log_internal::LogMessage::PrepareToDie()
    @           0xb94c31  absl::lts_20230802::log_internal::LogMessage::SendToLog()
    @           0xb946a7  absl::lts_20230802::log_internal::LogMessage::Flush()
    @           0xb94f14  absl::lts_20230802::log_internal::LogMessageFatal::~LogMessageFatal()
    @           0xb63078  google::protobuf::io::Printer::Validate()
    @           0xb652cb  google::protobuf::io::Printer::PrintImpl()
    @           0x45a6d8  google::protobuf::io::Printer::Print<>()
    @           0x4593a8  google::cloud::generator_internal::Printer::Print()
    @           0x4593fa  google::cloud::generator_internal::Printer::Print()
    @           0x4583df  google::cloud::generator_internal::PrintMethod()
    @           0x554d25  google::cloud::generator_internal::ServiceCodeGenerator::HeaderPrintMethod()
    @           0x594cd5  google::cloud::generator_internal::ClientGenerator::GenerateHeader()
    @           0x5558eb  google::cloud::generator_internal::ServiceCodeGenerator::Generate()

Looks like it is having trouble printing something in the pubs/sub service. Was looking at generator/internal/printer.h. Might be related to protobuf's printer.

@alevenberg
Copy link
Member Author

alevenberg commented Oct 20, 2023

Left on the TODO

  • add the ability to replace comments for the service

@alevenberg
Copy link
Member Author

Next step: #12987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

2 participants