Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GRPC_BAZEL_BUILD workaround when we drop Bazel 4.2 #10279

Closed
coryan opened this issue Nov 19, 2022 · 0 comments · Fixed by #10966
Closed

Remove GRPC_BAZEL_BUILD workaround when we drop Bazel 4.2 #10279

coryan opened this issue Nov 19, 2022 · 0 comments · Fixed by #10966
Assignees
@coryan
Labels
cpp: operator Good things for the operator to fix type: cleanup An internal cleanup or hygiene concern.

Comments

@coryan
Copy link
Contributor

coryan commented Nov 19, 2022

Our .bazelrc files define GRPC_BAZEL_BUILD because it is needed on macOS to workaround this bug:

bazelbuild/bazel#4341

The bug is fixed, and the fixes are in Bazel >= 5.0:

bazelbuild/bazel@ec55533
@coryan coryan added type: cleanup An internal cleanup or hygiene concern. cpp: operator Good things for the operator to fix labels Nov 19, 2022
@coryan coryan mentioned this issue Feb 28, 2023
Merged
@coryan coryan self-assigned this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
cpp: operator Good things for the operator to fix type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup: remove gRPC+macOS workaround coryan/google-cloud-cpp
1 participant
@coryan