Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "sideEffects" to package.json #2918

Open
filipw01 opened this issue Mar 18, 2022 · 1 comment
Open

Add "sideEffects" to package.json #2918

filipw01 opened this issue Mar 18, 2022 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@filipw01
Copy link

Bundlers think this library cannot be tree shaken. This results in this workaround in Remix https://remix.run/docs/en/v1/pages/gotchas#server-code-in-client-bundles

I suggest adding "sideEffects field to package.json
@filipw01 filipw01 added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 18, 2022
@mhio
Copy link

mhio commented Oct 24, 2023

#3354

@blimmer blimmer mentioned this issue Feb 2, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: package.json sideEffects field should be a boolean blimmer/google-api-nodejs-client
2 participants
@filipw01 @mhio