Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm timeout override works with retry #138

Closed
geigerj opened this issue Jun 2, 2017 · 1 comment
Closed

Confirm timeout override works with retry #138

geigerj opened this issue Jun 2, 2017 · 1 comment
Assignees
@alexander-fenster
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@geigerj
Copy link

geigerj commented Jun 2, 2017 •
edited
Loading

What

Confirm that

  my_api_client.idempotentRetryingCall(null, {timeout: 123})

in fact uses 123s as its initial timeout. If so, please close this bug.

Why

This ticket is just to confirm that NodeJS GAX doesn't suffer from the bug noted in Ruby GAX at googleapis/gax-ruby#71, since their implementations are similar.
@JustinBeckwith JustinBeckwith added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jun 1, 2018
@JustinBeckwith JustinBeckwith added the type: cleanup An internal cleanup or hygiene concern. label Jun 1, 2018
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Jun 8, 2018
@sduskis sduskis removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 5, 2019
@evaogbe evaogbe added the priority: p2 Moderately-important priority. Fix may not be included in next release. label May 13, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 13, 2019
@sduskis sduskis removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 13, 2019
@alexander-fenster
Copy link
Contributor

Closing - nobody uses it and we don't want to support it.

@alexander-fenster alexander-fenster self-assigned this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexander-fenster alexander-fenster

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sduskis @JustinBeckwith @evaogbe @alexander-fenster @geigerj @swcloud @yoshi-automation