Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin loader doesn't support circular requires #618

Closed
kjin opened this issue Nov 30, 2017 · 1 comment
Closed

Plugin loader doesn't support circular requires #618

kjin opened this issue Nov 30, 2017 · 1 comment
Assignees
@kjin
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@kjin
Copy link
Contributor

kjin commented Nov 30, 2017

In mysql2, lib/pool.js and index.js require each other. This causes an issue when the former is patched (like in #607), as the result of require('lib/pool.js') is an uninitialized placeholder object.
@kjin kjin added the bug label Nov 30, 2017
@kjin kjin self-assigned this Nov 30, 2017
@julienvincent julienvincent mentioned this issue Nov 30, 2017
Merged
@kjin kjin added in progress priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 20, 2018
@kjin
Copy link
Contributor Author

kjin commented Mar 23, 2018

This issue has been fixed in #686.

@kjin kjin closed this as completed Mar 23, 2018
@kjin kjin removed the in progress label Mar 23, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjin kjin

Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjin