Skip to content
This repository has been archived by the owner on Dec 12, 2021. It is now read-only.

all hosts changed in datastore by updating SANTA_DEFAULT_CLIENT_MODE in upvote/gae/shared/common/settings.py #21

Open
thehesiod opened this issue Oct 17, 2018 · 4 comments
Assignees

Comments

@thehesiod
Copy link

we had an accident where I accidentally deployed from the master branch instead of our personal branch, which ended up resetting SANTA_DEFAULT_CLIENT_MODE. I would have imagined this would have only affected new hosts, however ALL hosts ended up getting reset to lockdown mode triggering a lot of unhappiness :)

I think for hosts that are in the datastore should not be affected by a change to this variable.

@chief8192
Copy link
Contributor

Yeah, that definitely should not happen. Sorry for the trouble this caused. Can you tell if the new deployment somehow resulted in multiple SantaHost entities being created for a single device?

@chief8192 chief8192 self-assigned this Oct 17, 2018
@msuozzo
Copy link
Member

msuozzo commented Oct 17, 2018

Yeah this should not have happened. Looking at the code, it doesn't look like a change in this constant should have changed the settings of existing hosts. Are there other changes you've made on your branch that could have made the server think that it hadn't seen the host before?

@thehesiod
Copy link
Author

thehesiod commented Oct 17, 2018

Here are our current list of changes: master...farmersbusinessnetwork:master

@thehesiod
Copy link
Author

I don't see how any of the other changes could have caused it. Unfortunately we wiped the DB. I'm working on enabling backups so we can do rollbacks instead of wipes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants