Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathOpt: python_math_opt_solver_test timeout on macOS #4209

Closed
Mizux opened this issue Apr 29, 2024 · 5 comments
Closed

MathOpt: python_math_opt_solver_test timeout on macOS #4209

Mizux opened this issue Apr 29, 2024 · 5 comments
Assignees
Labels
Bug OS: Mac MacOS Solver: MathOpt MathOpt related issue
Milestone

Comments

@Mizux
Copy link
Collaborator

Mizux commented Apr 29, 2024

Branches/Version

On main or v99bugfix (v9.10 branch)

OS

  • Mac Intel/M1,
  • Python [3.8,3.12]

Protocol:

git checkout main
git pull -r
cmake -S. -Bbuild -DBUILD_PYTHON=ON
cmake --build build -j
(cd build && ctest -R "python_math_opt_solver_test")

Expected:

Like on Linux

Test project /usr/local/google/home/corentinl/work/main/build
    Start 20: python_math_opt_solver_test
1/1 Test #20: python_math_opt_solver_test ......   Passed    0.47 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   0.51 sec

Observed:

Test project /usr/local/google/home/corentinl/work/main/build
    Start 20: python_math_opt_solver_test
# blocking...

Hypotheses

The GIL management is not done correctly (contrary to MPSolver or CP-SAT) making the callback test hang forever...

@Mizux Mizux added Bug OS: Mac MacOS Solver: MathOpt MathOpt related issue labels Apr 29, 2024
@Mizux Mizux added this to the v9.10 milestone Apr 29, 2024
@rma350
Copy link
Collaborator

rma350 commented Apr 29, 2024

this is on linux or mac?

@arnabanimesh
Copy link
Contributor

@rma350 mac

@Mizux Mizux changed the title [python ]MathOpt solver_test timeout [python ]MathOpt solver_test timeout on macOS May 6, 2024
@Mizux Mizux modified the milestones: v9.10, v9.11 Jun 3, 2024
@Mizux Mizux modified the milestones: v9.11, v10.0 Aug 28, 2024
@Mizux Mizux assigned Mizux and rma350 and unassigned Mizux Oct 22, 2024
@Mizux Mizux modified the milestones: v10.0, v9.12 Dec 2, 2024
@Mizux
Copy link
Collaborator Author

Mizux commented Dec 2, 2024

seems fixed on main and v99bugfix

@Mizux Mizux closed this as completed Dec 2, 2024
@rma350
Copy link
Collaborator

rma350 commented Dec 2, 2024

Do we have any idea what changed? I did not change the code. Is the change caused by a different version of pybind11/absl/python/proto? Or just unknown?

@Mizux Mizux changed the title [python ]MathOpt solver_test timeout on macOS MathOpt: python_math_opt_solver_test timeout on macOS Dec 2, 2024
@Mizux
Copy link
Collaborator Author

Mizux commented Dec 2, 2024

Do we have any idea what changed? I did not change the code. Is the change caused by a different version of pybind11/absl/python/proto? Or just unknown?

a little bit of all of this + MathOpt do change since v9.10

git diff --shortstat v9.10..main ortools/math_opt/ 
 151 files changed, 5394 insertions(+), 1000 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug OS: Mac MacOS Solver: MathOpt MathOpt related issue
Projects
None yet
Development

No branches or pull requests

3 participants