Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve on screen content with translations #287

Closed
yschimke opened this issue Jun 28, 2022 · 2 comments
Closed

Resolve on screen content with translations #287

yschimke opened this issue Jun 28, 2022 · 2 comments
Labels
enhancement New feature or request Media UI Media UI related

Comments

@yschimke
Copy link
Collaborator

yschimke commented Jun 28, 2022

See #286 (comment)

nit: I see the benefit of the library providing default content descriptions to the icons it displays (which can be overridden to provide translations) but I feel that displaying a text on the screen in a specific language by default is more invasive and would rather require this as parameter to the component - I might be biased and maybe I should not see any difference in between these two scenarios

@yschimke yschimke self-assigned this Jun 28, 2022
@yschimke
Copy link
Collaborator Author

I suggest we try this default support in an external project, but also make sure that content can be passed in.

So review all content and how to pass in without becoming unwieldy. Also look at similar projects, maybe like getstream and how they achieve this.

Options

a) Remove the default text, and require param
b) keep default and confirm apps can provide other translations
c) b + with optional param to pass in

@yschimke yschimke added enhancement New feature or request Media UI Media UI related labels Jul 20, 2022
@yschimke yschimke removed their assignment Jan 31, 2023
@yschimke
Copy link
Collaborator Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Media UI Media UI related
Projects
None yet
Development

No branches or pull requests

1 participant