Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [LxgwWenKai-Lite] #4601

Open
8 of 9 tasks
Yuiinars opened this issue May 6, 2022 · 10 comments
Open
8 of 9 tasks

Add [LxgwWenKai-Lite] #4601

Yuiinars opened this issue May 6, 2022 · 10 comments
Assignees
Labels
I New Font II CJK Chinese, Japanese, Korean scripts II Submission pending proposal for non-commissioned fonts suggested in the issue tracker
Milestone

Comments

@Yuiinars
Copy link

Yuiinars commented May 6, 2022

Font Project Git Repo URL:
https://github.com/lxgw/LxgwWenKai-Lite

Super short description of the Font Family:
An open-source Chinese font derived from Fontworks' Klee One.

Requirements:
This font cannot be used for illegal purposes and the author is not responsible for any disputes or legal actions arising from the use of this font.
The sale of individual font files (OTF/TTF files) is prohibited in accordance with SIL Open Font License 1.1.

I understand that Google Fonts will publish only fonts that matches its requirements, and I can confirm the project meets them (by ticking the cases, or putting x between the square brackets in text mode):

  • The entire font project is licensed under the OFL
  • There is no "Reserved Font Name" mention in the OFL license
  • Family name is unique according to namecheck.fontdata.com
  • The font supports at least GF Latin Core glyphset
  • The repository respect the upstream repo structure
  • The source files are available in the repository
  • I read, agree and comply with the full contributing requirements
  • I am the author of the font or the author agreed to this submission
  • I will maintain the repository
@Yuiinars Yuiinars added I New Font II Submission pending proposal for non-commissioned fonts suggested in the issue tracker labels May 6, 2022
@Yuiinars Yuiinars changed the title Add [LxgwWenKai] Add [LxgwWenKai] and [LxgwWenKaiMono] May 6, 2022
@lxgw
Copy link

lxgw commented May 7, 2022

I'd prefer to submit the lite edition ...

Now both editions are ready to submit.

@Yuiinars
Copy link
Author

Yuiinars commented May 9, 2022

@lxgw I'd prefer to submit the lite edition ...

Sry, I open the new Google Fonts submission request without contacting you in advance
I think you are right, I will amend my font submission request

@Yuiinars Yuiinars changed the title Add [LxgwWenKai] and [LxgwWenKaiMono] Add [LxgwWenKai-Lite] May 9, 2022
@RosaWagner RosaWagner added -- Needs manager's opinion from upper level -- Missing sources Need to ask designer to upload sources in upstream repo -- Needs Upstream Resolution Upstream fix required before moving forward labels May 11, 2022
@davelab6
Copy link
Member

davelab6 commented May 12, 2022

@lxgw this is great work! Onboarding regionally-individuated versions of CJK fonts is something I'm broadly in support of.

I was not able to find the source files and build scripts to your OFL project repos, are they available?

Since the GF API uses Unicode Range subsetting, I think we ought to take the full project, not the lite one - but please correct me if I'm wrong that the 'lite' version is lighter in terms of smaller glyph set.

@davelab6 davelab6 removed the -- Needs manager's opinion from upper level label May 12, 2022
@NightFurySL2001
Copy link
Contributor

NightFurySL2001 commented May 13, 2022

Since the GF API uses Unicode Range subsetting, I think we ought to take the full project, not the lite one - but please correct me if I'm wrong that the 'lite' version is lighter in terms of smaller glyph set.

The full project contains glyphs that were generated using zi2zi which is of poor quality, although covering CJK Unified Ideogrpahs completely (and scattered Extension A to G). The Lite version which is smaller in glyph set only contains hand made glyphs and characters that are generally used in Simplified and Traditional Chinese, and no hangul characters.

@RosaWagner RosaWagner added this to the Important projects to be commissioned and milestoned milestone May 19, 2022
@NightFurySL2001
Copy link
Contributor

@RosaWagner @davelab6 Sources are uploaded to both repo with build script and modified to match upstream repo structure. I will help @lxgw to maintain the repository if needed.

@lxgw
Copy link

lxgw commented May 24, 2022

Since the GF API uses Unicode Range subsetting, I think we ought to take the full project, not the lite one - but please correct me if I'm wrong that the 'lite' version is lighter in terms of smaller glyph set.

Based on Klee One, the full edition contains all the characters of Basic CJK Unified Ideographs, several CJK Unified Ideograph Extensions (from Ext.A to Ext.H draft) and some Hangul Syllables in common use, while the lite edition contains characters commonly used in Simplified and Traditional Chinese and no Hangul characters.

But some glyphs in the full edition were generated by zi2zi-pytorch that the quality of them might be more terrible. The lite edition contains handmade glyphs only.

I was not able to find the source files and build scripts to your OFL project repos, are they available?

With the help of @NightFurySL2001, now the sources files and build scripts of both editions have been uploaded to their respective repositories, and both repositories have been modified to meet the upstream repo structure.

Since this issue is opened to submit the lite edition, may I open another issue to submit the full edition?

@lxgw
Copy link

lxgw commented Jun 16, 2022

The Traditional Chinese edition LXGW WenKai TC has been updated to v0.9 and the sources of each font file have been uploaded to the repo.

I have opened the issue #4802 to submit this font.

@medicalwei
Copy link

Note that this font has RFN "霞鹜" and "LXGW", and I am asking about it in lxgw/LxgwWenKai#80.

@RosaWagner RosaWagner added - Ready for Review II CJK Chinese, Japanese, Korean scripts and removed -- Needs Upstream Resolution Upstream fix required before moving forward -- Missing sources Need to ask designer to upload sources in upstream repo labels Sep 29, 2022
@RosaWagner RosaWagner modified the milestones: Projects to be commissioned and/or milestoned, Submissions to review Sep 29, 2022
@RosaWagner RosaWagner mentioned this issue Mar 10, 2023
9 tasks
@Honoka55
Copy link

I’d kindly request a reconsideration regarding the font’s copyright status in light of concerns raised in my earlier issue. Need further clarification whether the Lite version is also involved in the copyright issue.

@pkj-l
Copy link

pkj-l commented Dec 15, 2023

I’d kindly request a reconsideration regarding the font’s copyright status in light of concerns raised in my earlier issue. Need further clarification whether the Lite version is also involved in the copyright issue.

@Honoka55 Lite 版没有 AI 炼丹部分。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I New Font II CJK Chinese, Japanese, Korean scripts II Submission pending proposal for non-commissioned fonts suggested in the issue tracker
Projects
Status: Todo
Development

No branches or pull requests

10 participants