Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote cache miss due to incorrect @Input parameter #2763

Closed
remcomokveld opened this issue Jul 20, 2021 · 1 comment
Closed

Remote cache miss due to incorrect @Input parameter #2763

remcomokveld opened this issue Jul 20, 2021 · 1 comment

Comments

@remcomokveld
Copy link

remcomokveld commented Jul 20, 2021

We are seeing remote build cache misses on the com.android.build.gradle.tasks.TransformClassesWithAsmTask. It looks like this is because @Input is used instead of a combination @InputFile and @get:PathSensitive(PathSensitivity.RELATIVE) in the AndroidEntryPointClassVisitor.

interface AndroidEntryPointParams : InstrumentationParameters {
@get:Input
val additionalClassesDir: Property<File>
}

@runningcode
Copy link

This causes a 10+ second cache miss in every module where hilt is applied. This can add a significant amount of time in multi-module projects with hundreds of modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants