From e4a04b67c23adf4ce89059fea103acd58562be36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Szulik?= Date: Fri, 2 Oct 2020 18:47:20 +0200 Subject: [PATCH] Increase the readability of perf event logs. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Paweł Szulik --- manager/manager.go | 4 ++-- perf/uncore_libpfm.go | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/manager/manager.go b/manager/manager.go index 06e36ee8e0e..93dc9cffbb9 100644 --- a/manager/manager.go +++ b/manager/manager.go @@ -932,7 +932,7 @@ func (m *manager) createContainerLocked(containerName string, watchSource watche perfCgroupPath := path.Join(fs2.UnifiedMountpoint, containerName) cont.perfCollector, err = m.perfManager.GetCollector(perfCgroupPath) if err != nil { - klog.V(4).Infof("perf_event metrics will not be available for container %s: %s", containerName, err) + klog.Errorf("Perf event metrics will not be available for container %s: %s", containerName, err) } } else { devicesCgroupPath, err := handler.GetCgroupPath("devices") @@ -950,7 +950,7 @@ func (m *manager) createContainerLocked(containerName string, watchSource watche } else { cont.perfCollector, err = m.perfManager.GetCollector(perfCgroupPath) if err != nil { - klog.V(4).Infof("perf_event metrics will not be available for container %s: %s", containerName, err) + klog.Errorf("Perf event metrics will not be available for container %s: %s", containerName, err) } } } diff --git a/perf/uncore_libpfm.go b/perf/uncore_libpfm.go index 2e4cf20d53a..61346047d54 100644 --- a/perf/uncore_libpfm.go +++ b/perf/uncore_libpfm.go @@ -151,8 +151,7 @@ func NewUncoreCollector(cgroupPath string, events PerfEvents, cpuToSocket map[in err := collector.setup(events, systemDevicesPath) if err != nil { - formatedError := fmt.Errorf("unable to setup uncore perf event collector: %v", err) - klog.V(5).Infof("Perf uncore metrics will not be available: %s", formatedError) + klog.Errorf("Perf uncore metrics will not be available: unable to setup uncore perf event collector: %v", err) return &stats.NoopCollector{} }