You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched for similar issues before opening a new one.
Component
workspace-minimap
Problem
No response
Request
The workspace-minimap plugin does not have "strict mode" enabled for TypeScript. We should enable it to have better type checking for our plugins, but doing so may show some TypeScript errors that need to be fixed first.
This would be a good first issue for anyone experienced with working in TypeScript. You may need to adjust types, add checks for null or undefined, or make other fixes. If you have questions, feel free to ask here! In general, the team prefers avoiding casts and using ! to coerce non-null types, and instead adding appropriate checks.
To work on this issue:
Run npm install at the root of Blockly samples to set up dependencies.
Navigate to the plugin's directory
Change strict: false to strict: true in the plugin's tsconfig.json
Run npm run build and see if there are any TypeScript errors.
Resolve any TypeScript errors, if present. If not, then we got lucky and accidentally wrote strict code! Yay!
Run npm run build again to make sure there are no TypeScript errors.
Run npm run start and play with the plugin in the playground to make sure the plugin still behaves as expected.
Run npm run test to run any automated tests.
Run npm run lint to make sure there are no formatting errors.
Open a PR with your changes!
Alternatives considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
Check for duplicates
Component
workspace-minimap
Problem
No response
Request
The workspace-minimap plugin does not have "strict mode" enabled for TypeScript. We should enable it to have better type checking for our plugins, but doing so may show some TypeScript errors that need to be fixed first.
This would be a good first issue for anyone experienced with working in TypeScript. You may need to adjust types, add checks for null or undefined, or make other fixes. If you have questions, feel free to ask here! In general, the team prefers avoiding casts and using
!
to coerce non-null types, and instead adding appropriate checks.To work on this issue:
npm install
at the root of Blockly samples to set up dependencies.strict: false
tostrict: true
in the plugin's tsconfig.jsonnpm run build
and see if there are any TypeScript errors.npm run build
again to make sure there are no TypeScript errors.npm run start
and play with the plugin in the playground to make sure the plugin still behaves as expected.npm run test
to run any automated tests.npm run lint
to make sure there are no formatting errors.Alternatives considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: