Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish types for block-shareable-procedures #1897

Closed
BeksOmega opened this issue Sep 5, 2023 · 3 comments · Fixed by #1952
Closed

Publish types for block-shareable-procedures #1897

BeksOmega opened this issue Sep 5, 2023 · 3 comments · Fixed by #1952
Assignees
@Daphne-wu
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue Good for newcomers size: small type: feature request New feature or request

Comments

@BeksOmega
Copy link
Contributor

BeksOmega commented Sep 5, 2023 •
edited
Loading

🚧⚠️🚧 This issue is being saved for Grace Hopper Open Source Day. 🚧⚠️🚧 An event we're running to help girls and non-binary technologists make their first contributions to open source! Please see our list of help wanted issues if you'd like to contribute!

Category

  • Plugins

Component

block-shareable-procedure

Is your feature request related to a problem? Please describe.

Currently types for this plugin are not being generated or exported :/

Describe the solution you'd like

  1. Add the following config options to the "compilerOptions" section of the tsconfig.json
"declaration": true,
"declarationMap": true,
  1. Add the following property to the package.json next to the "main" property:
"types": "./dist/index.d.ts"

Additional context

Related to: #1892
@BeksOmega BeksOmega added type: feature request New feature or request good first issue Good for newcomers ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ labels Sep 5, 2023
@BeksOmega BeksOmega moved this to Ready for Work in Blockly GHC OSD Sep 5, 2023
@corners2wall corners2wall mentioned this issue Sep 6, 2023
Closed
@Daphne-wu
Copy link
Contributor

Hello! I am interested in this

@rldhanush
Copy link

@BeksOmega I am interested in working on this, thanks !!

@BeksOmega
Copy link
Contributor Author

Hiya @Daphne-wu Go for it!

@rl-dhanush Looks like @Daphne-wu got here first =) If you comment on a different issue I can get you assigned!

@Daphne-wu Daphne-wu mentioned this issue Sep 22, 2023
Merged
1 task
@BeksOmega BeksOmega linked a pull request Sep 29, 2023 that will close this issue
feat: Publish types for block-shareable-procedures #1952
Merged
1 task
@github-project-automation github-project-automation bot moved this from Ready for Work to Done Coding in Blockly GHC OSD Sep 29, 2023
@BeksOmega BeksOmega moved this from Done Coding to Needs Testing in Blockly GHC OSD Sep 29, 2023
@BeksOmega BeksOmega moved this from Needs Testing to Needs Fixes in Blockly GHC OSD Sep 29, 2023
@maribethb maribethb moved this from Needs Fixes to Done Testing in Blockly GHC OSD Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Daphne-wu Daphne-wu

Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue Good for newcomers size: small type: feature request New feature or request
Projects
No open projects
Blockly GHC OSD
Status: Done Testing
Milestone
No milestone
3 participants
@BeksOmega @Daphne-wu @rldhanush