Move string parsing logic from CommandLineParser class to ppx::string_util::ParseOrDefault()
#271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b2440b to
cd2032e
Compare
android/linux builds * Make mAllOptions strings and not string_views * Make the functions that need to search mAllOptions take input parameters of const std::string& instead
* JSON file flags are lower priority than flags specified on the command line * Using JSON is_array and is_object functions * Using round bracket syntax for initalization * Fix Parse() function * Better error reporting for parsing the JSON file * Fixed flag description typo
* Rename pConfigJsonPath to pConfigJsonPaths * Change commandline parsing to 2 initial passes for better readability
and command line flags to overwrite json files after that.
cd2032e to
b700c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(dependent on #265)
Move string parsing logic from
CommandLineParsertostring_util. I plan to re-use string parsing logic for generic knob input fields in ImGuiMinor changes:
ppx::string_util::Split()and changingSplitInTwo()to use it