New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move C++20 feature out of the header file. #262

Closed

at-ninja wants to merge 1 commit into google:main from at-ninja:cli-options

Contributor

at-ninja commented Aug 3, 2023

std::unordered_map::contains was added in C++20.

This keeps the header file C++17 compliant.


          Move C++20 feature out of the header file.

998aa6b

Member

Keenuts commented Aug 7, 2023

The project builds with C++20 by default (https://github.com/google/bigwheels/blob/main/CMakeLists.txt#L116).
This shouldn't be something we handle here.

at-ninja closed this

hysw mentioned this pull request

Change C++ standard to C++17. #277

Merged

at-ninja deleted the cli-options branch

September 28, 2023 21:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet