Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regrading an IMADAI sample asset fix #8984

Closed
GouravSna opened this issue May 25, 2021 · 2 comments
Closed

Regrading an IMADAI sample asset fix #8984

GouravSna opened this issue May 25, 2021 · 2 comments
Assignees
Labels

Comments

@GouravSna
Copy link

Couple of months back, I reported an issue to IMA team about an asset which was not working once I seek to the mid-roll.

Now, they are saying that this is fixed now and fix was in ExoPlayer v2.13.3. Because for this DAI asset, i did not see any log which tell me about the issue.
Can you please tell me what was the root cause of it ?

@marcbaechinger
Copy link
Contributor

The thread in the IMA SDK group thread is referring to #8890 which is marked as a duplicate of #8937. The fix for this was this commit: 8ded117

As far as I understand this was not related to the IMA SDK but a problem in the HLS implementation of ExoPlayer that is used by the IMA asset.

@ojw28
Copy link
Contributor

ojw28 commented May 26, 2021

Whilst I agree that the chain of messages and issues leads to 8ded117, that commit only landed in 2.14.0, so if the issue was really fixed in 2.13.3 then that commit can't be the relevant one.

That said, the chain of communication regarding this issue is quite confused and hard to untangle, so I don't think it's a good use of time to try and figure out whatever the real root cause was. If finding this out is very important to you and if you're able to reproduce the issue, then I'd suggest you perform a bisection of the commits in 2.13.3 to locate the one that fixed the issue.

@ojw28 ojw28 closed this as completed May 26, 2021
@google google locked and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants