-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dev-v2 to be pulled as gradle dependency eg SNAPSHOT #3859
Comments
this would be nice. |
We'll look into setting this up. |
Until we get round to setting this up properly, JitPack may be useful as a quick way to get a snapshot of the development branch. It makes snapshot builds on demand. To try this, I added |
Using JitPack downloads all the extensions, resulting in longer build times and a bigger APK file size. |
For general development and for doing releases where you care about APK size it's better to use a release version of the player. I think the JitPack option is only really suitable for testing changes on the development branch where you don't want to set up a source dependency on ExoPlayer. |
@andrewlewis For some reason, on my case, it shows it can't resolve it. It has multiple errors as such: ERROR: Unable to resolve dependency for ':app@debugAndroidTest/compileClasspath': Could not resolve com.github.google:ExoPlayer:dev-v2-SNAPSHOT. ERROR: Unable to resolve dependency for ':app@debugUnitTest/compileClasspath': Could not resolve com.github.google:ExoPlayer:dev-v2-SNAPSHOT. ERROR: Unable to resolve dependency for ':app@release/compileClasspath': Could not resolve com.github.google:ExoPlayer:dev-v2-SNAPSHOT. ERROR: Unable to resolve dependency for ':app@releaseUnitTest/compileClasspath': Could not resolve com.github.google:ExoPlayer:dev-v2-SNAPSHOT. How did it work for you? |
Did you add |
@andrewlewis I have. I've decided to give it another try, and have removed all of the temporary folders (build and gradle folders). Then it went fine... |
@AndroidDeveloperLB Glad to hear you got it to work. I just tried with the dev-v2 snapshot. Discussion of #5480 is not on-topic for this issue (but I expect someone will triage it soon). |
@andrewlewis I mean what did you write on the gradle file. This : |
It seems to work for me with |
@andrewlewis Worked for me too, but the issue remains. The video doesn't play on Google Pixel, yet on other devices I think it works fine. Anyway, thank you. For further talking about the issue, write there if you wish. |
Adding Building always results in an Error Is there any update to this dependency? |
The jitpack dependency is not working for me at the moment. There are some errors in their build logs about malformed XML test data, which might be related (or there may be something else going on). I'll fix the XML files and we can see whether that happens to unblock building the dev-v2 snapshot. |
Issue description
Would it be possible to add the dev-v2 branch as a gradle dependency, eg upload the artifacts on each commit.
Something like this:
compile 'com.google.android.exoplayer:exoplayer:2.6.1-dev-v2'
or
compile 'com.google.android.exoplayer:exoplayer:2.6.1-SNAPSHOT'
This would make testing new fixes easier and allow us to use the latest fixes and features without having to wait for an official release.
The text was updated successfully, but these errors were encountered: