Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dev-v2 to be pulled as gradle dependency eg SNAPSHOT #3859

Open
wezley98 opened this issue Feb 16, 2018 · 14 comments
Open

Allow dev-v2 to be pulled as gradle dependency eg SNAPSHOT #3859

wezley98 opened this issue Feb 16, 2018 · 14 comments
Assignees

Comments

@wezley98
Copy link

Issue description

Would it be possible to add the dev-v2 branch as a gradle dependency, eg upload the artifacts on each commit.

Something like this:
compile 'com.google.android.exoplayer:exoplayer:2.6.1-dev-v2'
or
compile 'com.google.android.exoplayer:exoplayer:2.6.1-SNAPSHOT'

This would make testing new fixes easier and allow us to use the latest fixes and features without having to wait for an official release.

@jarrodoxical
Copy link

this would be nice.

@andrewlewis
Copy link
Collaborator

We'll look into setting this up.

@andrewlewis
Copy link
Collaborator

andrewlewis commented Jun 19, 2018

Until we get round to setting this up properly, JitPack may be useful as a quick way to get a snapshot of the development branch. It makes snapshot builds on demand.

To try this, I added maven { url 'https://jitpack.io' } to repositories then added a dependency on implementation 'com.github.google:ExoPlayer:dev-v2-SNAPSHOT'. (Note: when I tried this the first time the gradle sync timed out, but after a few minutes the dependency was ready.)

@hacker1024
Copy link
Contributor

Using JitPack downloads all the extensions, resulting in longer build times and a bigger APK file size.

@andrewlewis
Copy link
Collaborator

For general development and for doing releases where you care about APK size it's better to use a release version of the player. I think the JitPack option is only really suitable for testing changes on the development branch where you don't want to set up a source dependency on ExoPlayer.

@AndroidDeveloperLB
Copy link

@andrewlewis For some reason, on my case, it shows it can't resolve it. It has multiple errors as such:
`
ERROR: Unable to resolve dependency for ':app@debug/compileClasspath': Could not resolve com.github.google:ExoPlayer:dev-v2-SNAPSHOT.
Show Details
Affected Modules: app

ERROR: Unable to resolve dependency for ':app@debugAndroidTest/compileClasspath': Could not resolve com.github.google:ExoPlayer:dev-v2-SNAPSHOT.
Show Details
Affected Modules: app

ERROR: Unable to resolve dependency for ':app@debugUnitTest/compileClasspath': Could not resolve com.github.google:ExoPlayer:dev-v2-SNAPSHOT.
Show Details
Affected Modules: app

ERROR: Unable to resolve dependency for ':app@release/compileClasspath': Could not resolve com.github.google:ExoPlayer:dev-v2-SNAPSHOT.
Show Details
Affected Modules: app

ERROR: Unable to resolve dependency for ':app@releaseUnitTest/compileClasspath': Could not resolve com.github.google:ExoPlayer:dev-v2-SNAPSHOT.
Show Details
Affected Modules: app
`

How did it work for you?
Attached sample project.

ExoPlayerTest.zip

@andrewlewis
Copy link
Collaborator

Did you add maven { url 'https://jitpack.io' } to the repositories as described above? It seems to be working for me though maybe the dependency has been cached locally.

@AndroidDeveloperLB
Copy link

@andrewlewis I have. I've decided to give it another try, and have removed all of the temporary folders (build and gradle folders). Then it went fine...
Anyway, which version do you use? And, can you please check if your version can play the problematic video that I've reported here (it's the reason of why I'm trying to get a newer version) :

#5480

@andrewlewis
Copy link
Collaborator

@AndroidDeveloperLB Glad to hear you got it to work. I just tried with the dev-v2 snapshot.

Discussion of #5480 is not on-topic for this issue (but I expect someone will triage it soon).

@AndroidDeveloperLB
Copy link

@andrewlewis I mean what did you write on the gradle file. This :
implementation 'com.github.google:ExoPlayer:dev-v2-SNAPSHOT' ?
I've tried it, and still got an issue. I think it's only on Google Pixel , but not on other devices. It even occurs on Google Photos app there...

@andrewlewis
Copy link
Collaborator

It seems to work for me with implementation 'com.github.google.ExoPlayer:exoplayer:dev-v2-SNAPSHOT' so could you try that?

@AndroidDeveloperLB
Copy link

@andrewlewis Worked for me too, but the issue remains. The video doesn't play on Google Pixel, yet on other devices I think it works fine. Anyway, thank you. For further talking about the issue, write there if you wish.

@christianfrank84
Copy link

Adding maven { url 'https://jitpack.io' } and implementation 'com.github.google:ExoPlayer:dev-v2-SNAPSHOT' doesn't seem to work any longer.

Building always results in an Error Could not find com.github.google.ExoPlayer:exoplayer:dev-v2-SNAPSHOT.

Is there any update to this dependency?

@andrewlewis
Copy link
Collaborator

The jitpack dependency is not working for me at the moment. There are some errors in their build logs about malformed XML test data, which might be related (or there may be something else going on). I'll fix the XML files and we can see whether that happens to unblock building the dev-v2 snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants