Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option for post job cleanup of creds #402

Closed
marengaz opened this issue Nov 3, 2021 · 1 comment · Fixed by #405
Closed

add option for post job cleanup of creds #402

marengaz opened this issue Nov 3, 2021 · 1 comment · Fixed by #405

Comments

@marengaz
Copy link

marengaz commented Nov 3, 2021

TL;DR

option for post job cleanup of creds

Design

Action YAML

      - uses: google-github-actions/setup-gcloud@master
        with:
          project_id: my-project
          service_account_key: ${{ secrets.MY_SA_KEY }}
          export_default_credentials: true
          post_job_credential_cleanup: true

a rudimentary way to do this would be something like:

rm -f "$GOOGLE_APPLICATION_CREDENTIALS"
unset GOOGLE_APPLICATION_CREDENTIALS

Additional information
gives confidence that if a worker is reused, the creds wont still be hanging around

@uportalis
Copy link

I think such clean-up should be enabled by default.

@sethvargo sethvargo transferred this issue from google-github-actions/setup-gcloud Nov 30, 2021
@sethvargo sethvargo self-assigned this Nov 30, 2021
@sethvargo sethvargo transferred this issue from google-github-actions/auth Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants