-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rocker gestures involving the middle mouse button #9
base: master
Are you sure you want to change the base?
Conversation
This was already done for the mouse button that is released first, but not for one released last.
I've added three more commits that fix some stuff related to rocker gestures. I also realized that I should have based this pull request on a topic branch. And also that localization usind DTDs and entities is really not that fun (no fallback). |
Thanks for your patch. Now I'm reviewing it. |
I see what you mean. One option could be to use images (e.g. similar to those used by Mouse Gestures Redox, see the icon in [1]) instead of a textual description so that two rocker gestures would fit on one line next to each other (this would also make the localization easier). An alternative would be to introduce another prefpane to configure rocker gestures (or add tabs for different types of advanced gestures on the Advanced prefpane). Another option, inspired by Mouse Gestures Redox, would be the ability to assign rocker gestures (and other types of gestures, like mouse-wheel gestures) to individual built-in actions or scripts directly. When going for this option one has to consider that it is currently possible to assign the same action to more than one gesture (e.g. to a rocker gesture and a regular gesture or to two rocker gestures). On the other hand, what FireGestures currently does not support is the assignment of an action to two or more regular gestures (which, I suppose, could be added when implementing this). [1] http://www.mousegestures.org/exchange/details.php?mappingID=104 |
Is there anything left to do in this issue aside from pulling the changes? I'd be happy to help out, since I'm a fan of rocker gestures. |
I've pushed a commit that adds support for rocker gestures in which the middle mouse button is part of (a total of four new gestures). It would be great if you could consider it to be included in one of the next releases.
Some notes:
If you have any complaints or suggestions on how to improve the patch, I'm happy to change it.