Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocker gestures involving the middle mouse button #9

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tobiasbrunner
Copy link

I've pushed a commit that adds support for rocker gestures in which the middle mouse button is part of (a total of four new gestures). It would be great if you could consider it to be included in one of the next releases.

Some notes:

  • Because the new gestures aren't really usable if autoscroll is enabled, autoscroll gets disabled when the extension is loaded and the new rocker gestures are enabled.
  • In the preferences dialog I have separated the new gestures from the other rocker gestures because of the incompatibility with autoscroll, so users can still use the existing rocker gestures together with autoscroll.
  • I wasn't sure about the prefs-generic.xul file, I just added my stuff analog to the previous rocker gestures.
  • I've only added localization for en-US.

If you have any complaints or suggestions on how to improve the patch, I'm happy to change it.

@tobiasbrunner
Copy link
Author

I've added three more commits that fix some stuff related to rocker gestures. I also realized that I should have based this pull request on a topic branch. And also that localization usind DTDs and entities is really not that fun (no fallback).

@gomita
Copy link
Owner

gomita commented Mar 29, 2011

Thanks for your patch. Now I'm reviewing it.
The rocker gestures with middle-button seems to work fine so far.
However, there is a problem that the Options window is too much high for the usual screen size.
I think we need some more improvements to make the Options window fit to usual screen size.

@gomita gomita closed this Mar 29, 2011
@gomita gomita reopened this Mar 29, 2011
@tobiasbrunner
Copy link
Author

However, there is a problem that the Options window is too much high for the usual screen size.

I see what you mean. One option could be to use images (e.g. similar to those used by Mouse Gestures Redox, see the icon in [1]) instead of a textual description so that two rocker gestures would fit on one line next to each other (this would also make the localization easier).

An alternative would be to introduce another prefpane to configure rocker gestures (or add tabs for different types of advanced gestures on the Advanced prefpane).

Another option, inspired by Mouse Gestures Redox, would be the ability to assign rocker gestures (and other types of gestures, like mouse-wheel gestures) to individual built-in actions or scripts directly. When going for this option one has to consider that it is currently possible to assign the same action to more than one gesture (e.g. to a rocker gesture and a regular gesture or to two rocker gestures). On the other hand, what FireGestures currently does not support is the assignment of an action to two or more regular gestures (which, I suppose, could be added when implementing this).

[1] http://www.mousegestures.org/exchange/details.php?mappingID=104

@jimporter
Copy link

Is there anything left to do in this issue aside from pulling the changes? I'd be happy to help out, since I'm a fan of rocker gestures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants