Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom plugin version is not actually supported #4654

Closed
5 tasks done
whs opened this issue Apr 17, 2024 · 1 comment · Fixed by #4655
Closed
5 tasks done

Custom plugin version is not actually supported #4654

whs opened this issue Apr 17, 2024 · 1 comment · Fixed by #4655
Assignees
Labels
bug Something isn't working linter: custom About custom/private linters

Comments

@whs
Copy link

whs commented Apr 17, 2024

Welcome

Description of the problem

In https://golangci-lint.run/plugins/module-plugins/#reference the plugins.*.version field is documented, however the version field is actually unused:

image

Version of golangci-lint

$ golangci-lint --version
golangci-lint has version v1.57.2 built with go1.21.7 from (unknown, modified: ?, mod sum: "h1:NNhxfZyL5He1WWDrIvl1a4n5bvWZBcgAqBwlJAAgLTw=") on (unknown)

Configuration

version: v1.57.2
name: golangci-lint
destination: .bin

plugins:
  - module: internal
    import: internal
    version: v2.0.0

Go environment

$ go version && go env
go version go1.21.7 linux/amd64
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/whs/.cache/go-build'
GOENV='/home/whs/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/whs/go/pkg/mod'
GONOPROXY='<private>'
GONOSUMDB='<private>'
GOOS='linux'
GOPATH='/home/whs/go'
GOPRIVATE='<private>'
GOPROXY='<private>'
GOROOT='/nix/store/khpb8wx5dvf3bshb0iz9dm23z83r6niv-go-1.21.7/share/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/nix/store/khpb8wx5dvf3bshb0iz9dm23z83r6niv-go-1.21.7/share/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.7'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='<private>'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build90508159=/tmp/go-build -gno-record-gcc-switches'

Verbose output of running

N/A

A minimal reproducible example or link to a public repository

  1. Copy the config file above to .custom-gcl.yml and
  2. Point the custom plugin somewhere and refer to a version that is not @latest
  3. Run golangci-lint custom -v
  4. Observe that the resulting binary use the version @latest and not the pinned version

Validation

  • Yes, I've included all information above (version, config, etc.).
@whs whs added the bug Something isn't working label Apr 17, 2024
Copy link

boring-cyborg bot commented Apr 17, 2024

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez ldez self-assigned this Apr 17, 2024
@ldez ldez added the linter: custom About custom/private linters label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linter: custom About custom/private linters
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants