Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/websocket: remove Gorilla recommendation in docs #57228

Closed
percybolmer opened this issue Dec 10, 2022 · 2 comments
Closed

x/net/websocket: remove Gorilla recommendation in docs #57228

percybolmer opened this issue Dec 10, 2022 · 2 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@percybolmer
Copy link

What version of Go are you using (go version)?

1.18

Does this issue reproduce with the latest release?

No Issue

What operating system and processor architecture are you using (go env)?

What did you do?

Read the docs

What did you expect to see?

How to use the x/net/websocket library

What did you see instead?

https://github.com/golang/net/blob/e1ec361d0b39748d321472b2be7298211e05a3b6/websocket/websocket.go#L11
Gorilla recommendation which is now archived
@gopherbot gopherbot added this to the Unreleased milestone Dec 10, 2022
@seankhliao seankhliao changed the title x/net: Remove Gorilla Recommendation in Docs x/net/websocket: remove Gorilla recommendation in docs Dec 10, 2022
@seankhliao seankhliao added Documentation Issues describing a change to documentation. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 10, 2022
@seankhliao
Copy link
Member

archived: https://github.com/gorilla/websocket

cc @neild @ianlancetaylor

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/457356 mentions this issue: websocket: don't recommend Gorilla

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 13, 2022
@golang golang locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @percybolmer @gopherbot @seankhliao