proposal: gofmt semicolon before if-return statements

[jozef-slezak]

Let's allow a semicolon before short inlined if-return to cleanup error handling code - like this:

err := funcX(); if err != nil { return err }
err = funcY(); if err != nil { return err }

Nowdays gofmt replaces the code like this:

err := funcX()
if err != nil {
   return err
}
err = funcY()
if err != nil {
   return err
}

Pros:

• easy to understand
• cleans up repeated if err code (demonstrated on example above)
• simple change in gofmt

Cons:

• return statement would not be prominent (see proposal: gofmt should allow short inlined if-return statements #27135 )

This issue is related to: #27135 and also error handling design of GO2 (I have already posted some feedback in https://gist.github.com/jozef-slezak/93a7d9d3d18d3fce3f8c3990c031f8d0 but I think we should consider this simple and readable gofmt change even in GO1).

[bronze1man]

It is strange that I think One statement one line is easy to understand/read to me.

I think putting a lot of stuff into one line, just make the code difficult to read.

So I proposal another syntax:

func funcX() (error){
  return nil
}
func funcY() (int,errror){
  return 0,nil
}
func aaa() (int,error){
  try funcX();
  a := try funcY();
  return a,nil
}

The try just check the last function return parameters is error type ,if that err value is not nil, return the parent function with that error value at that line and do not run code after that line.

Also see https://ziglang.org/documentation/master/#try

[networkimprov]

See also...
Go2 drafts error handling: https://go.googlesource.com/proposal/+/master/design/go2draft.md
Community feedback: https://github.com/golang/go/wiki/Go2ErrorHandlingFeedback

[rsc]

Duplicate of #27135, or at least same answer.