Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/exec: TestExitCode failing on Plan 9 #27294

Closed
0intro opened this issue Aug 28, 2018 · 2 comments
Closed

os/exec: TestExitCode failing on Plan 9 #27294

0intro opened this issue Aug 28, 2018 · 2 comments

Comments

@0intro
Copy link
Member

0intro commented Aug 28, 2018

CL 125443 added TestExitCode. However, this test is failing on Plan 9, because Plan 9 programs return a string and not an exit code.

--- FAIL: TestExitCode (0.05s)
    exec_test.go:178: ExitCode got 1, want 42
    exec_test.go:186: ExitCode got 1, want 2
    exec_test.go:194: ExitCode got 1, want 255
FAIL
FAIL	os/exec	1.426s

See https://build.golang.org/log/8411cb50158709f843f78d9c6634bf005b6dc1fb

@0intro 0intro added this to the Go1.12 milestone Aug 28, 2018
@0intro 0intro self-assigned this Aug 28, 2018
@fhs
Copy link
Contributor

fhs commented Aug 28, 2018

It should just accept those results on Plan 9. It doesn't seem worth it to parse the int out. Even then, exit "0" would be a special case.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/131855 mentions this issue: os/exec: pass ExitCode tests on Plan 9

@golang golang locked and limited conversation to collaborators Aug 28, 2019
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants