-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syscall: Getpagesize should consult OS on arm64 #13191
Labels
Milestone
Comments
This is causing an issue in Docker running on arm64 with the new overlay driver. We use the pagesize to determine when we the mount arguments are too large. It would be preferable to report the PageSize as the minimum value rather than the maximum to avoid unexpected truncation to syscalls. |
Thanks @dmcgowan - good catch! |
Oh, yeah, @aclements already did this in 1b9499b |
This was referenced Jan 13, 2017
v1.14.0-dev, ARMv8: Making bundle: test-unit (in bundles/1.14.0-dev/test-unit) fails
moby/moby#29258
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There is code in src/syscall/syscall_linux_arm64.go file:
But this architecture supports three values for PAGE_SIZE: 4K, 16K and 64K which are selected at kernel compilation time.
Userspace is expected to check which value is set. Simplest solution is to use sysconf(_SC_PAGESIZE) function call (same as getpagesize()).
The text was updated successfully, but these errors were encountered: