From 10124c2631893fc944a98880796eadd7df048c37 Mon Sep 17 00:00:00 2001 From: Keith Randall Date: Tue, 24 Jan 2023 16:11:06 +0000 Subject: [PATCH] [release-branch.go1.20] Revert "cmd/compile: teach prove about bitwise OR operation" This reverts commit 3680b5e9c4f42fcf9155aa42b3b344d1fbe19571. Reason for revert: causes long compile times on certain functions. See issue #57959 Change-Id: Ie9e881ca8abbc79a46de2bfeaed0b9d6c416ed42 Reviewed-on: https://go-review.googlesource.com/c/go/+/463295 Run-TryBot: Keith Randall Reviewed-by: David Chase Reviewed-by: Cherry Mui TryBot-Result: Gopher Robot Reviewed-by: Cuong Manh Le (cherry picked from commit a6ddb15f8f5955d93eeb2f674ec564ffd4530c18) Reviewed-on: https://go-review.googlesource.com/c/go/+/463415 Run-TryBot: Matthew Dempsky Reviewed-by: Keith Randall Auto-Submit: Matthew Dempsky Reviewed-by: Keith Randall --- src/cmd/compile/internal/ssa/prove.go | 3 --- test/prove.go | 5 ----- 2 files changed, 8 deletions(-) diff --git a/src/cmd/compile/internal/ssa/prove.go b/src/cmd/compile/internal/ssa/prove.go index 908fb5af465e9b..9ecd335b6a06c2 100644 --- a/src/cmd/compile/internal/ssa/prove.go +++ b/src/cmd/compile/internal/ssa/prove.go @@ -856,9 +856,6 @@ func prove(f *Func) { case OpAnd64, OpAnd32, OpAnd16, OpAnd8: ft.update(b, v, v.Args[1], unsigned, lt|eq) ft.update(b, v, v.Args[0], unsigned, lt|eq) - case OpOr64, OpOr32, OpOr16, OpOr8: - ft.update(b, v, v.Args[1], unsigned, gt|eq) - ft.update(b, v, v.Args[0], unsigned, gt|eq) case OpPhi: // Determine the min and max value of OpPhi composed entirely of integer constants. // diff --git a/test/prove.go b/test/prove.go index 7792b432f964aa..c91fb26c04c1b3 100644 --- a/test/prove.go +++ b/test/prove.go @@ -1053,11 +1053,6 @@ func issue51622(b []byte) int { return 0 } -func issue45928(x int) { - combinedFrac := (x) / (x | (1 << 31)) // ERROR "Proved Neq64$" - useInt(combinedFrac) -} - //go:noinline func useInt(a int) { }