jsonPB marshaller with Enum as map value marshals enum to int

[espang]

Hi,

I found a inconsistency when I use the jsonpb marshaller with EnumAsInt not set. I have following messages defined in my proto file:

enum State {
    state1 = 0;
    state2 = 1;
}

message StatesResponse {
    map<string, State> states = 1;
}

message StateResponse {
    State state = 1;
}

The first one gets marshalled to:

{"states":{"18777d46-48b0-4659-8b72-f8ca69ee6536":1}}

the second one to:

{"state":"STATE2"}

[awalterschulze]

Interesting. Do you think golang/protobuf has the same problem, or is it gogo/protobuf specific?

[espang]

I don't know. We use gogo/protobuf and I only tested that. Will do a test with golang/protobuf

[timonwong]

EDIT: golang/protobuf has exactly the same issue:

https://github.com/golang/protobuf/blob/master/jsonpb/jsonpb_test.go#L388-L389

protobuf/jsonpb/jsonpb_test.go

Lines 385 to 387 in 58efb20

	// TODO: This is broken.
	//{"map<string, enum>", marshaler, &pb.Mappy{Enumy: map[string]pb.Numeral{"XIV": pb.Numeral_ROMAN}}, `{"enumy":{"XIV":"ROMAN"}`},
	{"map<string, enum as int>", Marshaler{EnumsAsInts: true}, &pb.Mappy{Enumy: map[string]pb.Numeral{"XIV": pb.Numeral_ROMAN}}, `{"enumy":{"XIV":2}}`},

See golang/protobuf#408

[awalterschulze]

Thank you @timonwong
Lets wait for golang/protobuf to fix this.
Then I will merge in their fix into gogo/protobuf.

[timonwong]

Update: As of golang/protobuf#645, it should be fixed?

[briansorahan]

@awalterschulze This would be really nice to have. Any ETA? I pulled gogo master in my GOPATH and ran a test and am seeing this exact issue.
It looks like golang/protobuf#645 was merged July 7, do you cherry pick or merge their master to yours?

[awalterschulze]

@jmarais and @donaldgraham are the new maintainers of this project. Maybe they can take a look.

[briansorahan]

Ok thx for the quick response @awalterschulze