-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference enum by string in grpc-gateway doesn't work #286
Comments
Could you please explain what you mean with reference?
…On Tue, 25 Apr 2017, 00:11 foolusion, ***@***.***> wrote:
With the standard protoc_gen_go I can reference Enum's by their string
name when using grpc-gateway. This is not the case when I use gogo binaries.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#286>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvsLTjd3D6r5co5iOVklatJ6VPhzMhIks5rzR4tgaJpZM4NGxwC>
.
|
You might want to use the goproto_registration extension which is not
documented for some reason
…On Tue, 25 Apr 2017, 09:26 Walter Schulze, ***@***.***> wrote:
Could you please explain what you mean with reference?
On Tue, 25 Apr 2017, 00:11 foolusion, ***@***.***> wrote:
> With the standard protoc_gen_go I can reference Enum's by their string
> name when using grpc-gateway. This is not the case when I use gogo binaries.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#286>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABvsLTjd3D6r5co5iOVklatJ6VPhzMhIks5rzR4tgaJpZM4NGxwC>
> .
>
|
I could've sworn there was documentation added when that extension was added. It must've disappeared at some point. |
It appears it was only added to https://github.com/gogo/protobuf/blob/master/gogoproto/doc.go#L151 |
Yes me too
…On Tue, 25 Apr 2017, 10:32 Johan Brandhorst, ***@***.***> wrote:
It appears it was only added to gogoproto/doc.go and not extensions.md:
https://github.com/gogo/protobuf/blob/master/gogoproto/doc.go#L151
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#286 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvsLSC5Awrwt29wAEs5CDZuoRbp42JSks5rza-FgaJpZM4NGxwC>
.
|
Thanks for pointing out the extension. That solved my issue! |
I added it to extensions now. Thanks @johanbrandhorst |
Glad to hear that this solved your problem :) @foolusion |
With the standard protoc_gen_go I can reference Enum's by their string name when using grpc-gateway. This is not the case when I use gogo binaries.
The text was updated successfully, but these errors were encountered: