Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference enum by string in grpc-gateway doesn't work #286

Closed
foolusion opened this issue Apr 24, 2017 · 8 comments
Closed

Reference enum by string in grpc-gateway doesn't work #286

foolusion opened this issue Apr 24, 2017 · 8 comments

Comments

@foolusion
Copy link

With the standard protoc_gen_go I can reference Enum's by their string name when using grpc-gateway. This is not the case when I use gogo binaries.

@awalterschulze
Copy link
Member

awalterschulze commented Apr 25, 2017 via email

@awalterschulze
Copy link
Member

awalterschulze commented Apr 25, 2017 via email

@johanbrandhorst
Copy link
Member

I could've sworn there was documentation added when that extension was added. It must've disappeared at some point.

@johanbrandhorst
Copy link
Member

It appears it was only added to gogoproto/doc.go and not extensions.md:

https://github.com/gogo/protobuf/blob/master/gogoproto/doc.go#L151

@awalterschulze
Copy link
Member

awalterschulze commented Apr 25, 2017 via email

@foolusion
Copy link
Author

Thanks for pointing out the extension. That solved my issue!

@awalterschulze
Copy link
Member

I added it to extensions now. Thanks @johanbrandhorst

@awalterschulze
Copy link
Member

awalterschulze commented Apr 25, 2017

Glad to hear that this solved your problem :) @foolusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants