Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a EqualIgnoreOrder function #284

Closed
swelly127 opened this issue Apr 20, 2017 · 3 comments
Closed

Implement a EqualIgnoreOrder function #284

swelly127 opened this issue Apr 20, 2017 · 3 comments

Comments

@swelly127
Copy link

During testing we may want to compare protos but we can't always predict the order the elements of the slice will be in. I have code that does this, if you guys add me as a contributor I can make a request

@awalterschulze
Copy link
Member

You are always welcome to make a pull request and if it gets merged you can become an CONTRIBUTOR or an AUTHOR, whichever is appropriate in terms of copyright.

Its always useful though to first have a design discussion, but if the work is very little, like in this case, its really nice to be able to talk concretely about the code.
I will now go and look at the pull request.

@awalterschulze
Copy link
Member

#285

@awalterschulze
Copy link
Member

I am closing this, but just comment if you would like it reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants