Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 [Maintenance]: fasthttp dependency tag of v1.59.0 #3310

Closed
3 tasks done
pjebs opened this issue Feb 14, 2025 · 5 comments
Closed
3 tasks done

🧹 [Maintenance]: fasthttp dependency tag of v1.59.0 #3310

pjebs opened this issue Feb 14, 2025 · 5 comments

Comments

@pjebs
Copy link
Contributor

pjebs commented Feb 14, 2025

Maintenance Task Description

valyala/fasthttp#1955

On Mon/Tue, fasthttp will have a new update: v1.59.0.

It would be great if Fiber v2.52.7 could be created to use the new updated fasthttp.

If I create a PR, do I branch off 2.52.6 or append to main?

Impact on the Project

No response

Additional Context (optional)

No response

Checklist:

  • I have confirmed that this maintenance task is currently not being addressed.
  • I understand that this task will be evaluated by the maintainers and prioritized accordingly.
  • I am available to provide further information if needed.
@JIeJaitt
Copy link
Contributor

@pjebs create a PR from main

@pjebs
Copy link
Contributor Author

pjebs commented Feb 16, 2025

@JIeJaitt @ReneWerner87 Has development on v2 stopped? The docs on the site still point to v2.

@ReneWerner87
Copy link
Member

Well in v2 we don't want to add any more new features so we can concentrate on v3 and finally get the work there to the point for a release
We can do a fasthttp update if it doesn't cause any breaking changes

@gaby
Copy link
Member

gaby commented Feb 25, 2025

@pjebs This update can only be applied to v3 which we did yesterday here #3314

Recent fasthttp requires go1.22 which is not compatible with fiber v2.

@pjebs
Copy link
Contributor Author

pjebs commented Feb 25, 2025

Awesome.

@pjebs pjebs closed this as completed Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants