Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The failed withdrawal transaction will remain in the history record #298

Closed
Dawn-githup opened this issue Apr 18, 2023 · 2 comments · Fixed by #300 or #304
Closed

The failed withdrawal transaction will remain in the history record #298

Dawn-githup opened this issue Apr 18, 2023 · 2 comments · Fixed by #300 or #304
Assignees
@oriole-pub
Labels
UI

Comments

@Dawn-githup
Copy link

Dawn-githup commented Apr 18, 2023 •
edited by Flouse
Loading

Steps to reproduce the behavior:

1.Continuously submitting multiple withdrawal requests.
2.Unprocessed withdrawal requests (e.g. failed over withdrawal) will remain in the history record.

image

Transaction hash： 0x81dd4415e37eee1d7581f1f5e9c18e9a388a9606d8984715cb10d6bcca3a7ad5
@Dawn-githup Dawn-githup changed the title The failed withdrawal transaction will remain in the history record. The failed withdrawal transaction will remain in the history record Apr 18, 2023
@Dawn-githup Dawn-githup added the UI label Apr 18, 2023
@Flouse
Copy link
Collaborator

Flouse commented Apr 20, 2023 •
edited
Loading

Reproduce the problem

image

  1. I submitted 2 withdrawal requests which contained a over withdrawal.
  2. A few seconds later, the over withdrawal disappeared.
  3. But when I refreshed the page or switched between Pending and Completed tabs, the over withdrawal came back.

What is a over withdrawal?

Let's say a user only has 1000 CKB on layer-2, and he requests a 800 CKB withdrawal, and then immediately request another 600 CKB withdrawal. Then we say that 600 CKB withdrawal is an over withdrawal.

Simple workaround

Because the WithdrawalWithStatus from Godwoken RPC only has 2 status: pending | committed, it is not convinient to reveal the status of a failed withdrawal. So, I provide a simple solution:

@Dawn-githup
Copy link
Author

Dawn-githup commented Apr 29, 2023 •
edited by Flouse
Loading

This was linked to pull requests Apr 30, 2023
Fix the status of a long time l2Pending withdrawal #300
Merged
Fix: remove outdated failed withdrawals #304
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oriole-pub oriole-pub

Labels
UI
Projects
None yet
Milestone
No milestone
3 participants
@Flouse @Dawn-githup @oriole-pub