Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(4.4-dev3) Bad spacing in Text Editor when Code Folding is disabled #98521

Closed
caioraphael1 opened this issue Oct 25, 2024 · 5 comments · Fixed by #98543
Closed

(4.4-dev3) Bad spacing in Text Editor when Code Folding is disabled #98521

caioraphael1 opened this issue Oct 25, 2024 · 5 comments · Fixed by #98543

Comments

@caioraphael1
Copy link

caioraphael1 commented Oct 25, 2024

Tested versions

4.4-dev3

System information

Windows 10, Ryzen 3 3300x, 16gb RAM 2666mhz, GTX 1660 6gb.

Issue description

I'm not sure if this is a bug, or is intended, so I apologize in advance. Either way, I dislike the new look.

When Code Folding is disabled, there's no spacing between the number and the code.

4.4-dev3
image

4.3-stable
image

Also, if possible, I'd like to understand the changes in the overall theme in the editor. Why does everything seem bold and brighter?

4.4-dev3
image

4.3-stable
image

I personally didn't like at all the theme changes.

Steps to reproduce

Don't apply.

Minimal reproduction project (MRP)

Don't apply.

@AThousandShips

This comment was marked as resolved.

@caioraphael1 caioraphael1 changed the title (4.3-dev3) Bad spacing in Text Editor when Code Folding is disabled (4.4-dev3) Bad spacing in Text Editor when Code Folding is disabled Oct 25, 2024
@caioraphael1
Copy link
Author

Do you mean 4.4.dev3? Otherwise please try a more recent version like 4.3.stable or 4.4.dev3

yes, I mistyped, I'm an idiot

@caioraphael1
Copy link
Author

I have downgraded the project from 4.4-dev3 to 4.3-stable, and the line spacing was fixed, but the high saturation colors in the editor was not.

After messing around, I've decided to disable 2D HDR and it worked. For some reason the 2D HDR is affecting the colors in the editor as well, which I don't think is intended

@matheusmdx
Copy link
Contributor

Bisecting points to #92865 as the culprit, @rune-scape

image

@Calinou
Copy link
Member

Calinou commented Oct 30, 2024

The brightness issue is due to #80868. It could be fixed by using different opacity values in the editor theme when HDR 2D is enabled in the project settings, but the alpha factors need to be caredully chosen.

@AThousandShips AThousandShips added this to the 4.4 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants