Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing Pause/Stop while paused in the Bezier Curve Editor view will cause the AnimationPlayer Editor to jump to the Track Editor view #89216

Open
Arnklit opened this issue Mar 6, 2024 · 1 comment

Comments

@Arnklit
Copy link
Contributor

Arnklit commented Mar 6, 2024

Tested versions

4.2.1.stable and Master

System information

Windows 11, Vulkan, Forward+

Issue description

If you are in the bezier view of an animation and press the stop/pause button while the animation isn't playing, it will jump to the beginning of the animation correctly, but it will also jump out of the bezier view back into the track view.

Godot_v4.2.1-stable_win64_oAMoQygIJs.mp4

This seems to be because the animation is reassigned when pressing the pause button.

Commenting out this line will resolve the issue, but I'm guessing the assignment happens for a reason.

player->set_assigned_animation(current);

I believe the issue was introduced with this PR. #71321

Steps to reproduce

  1. Create an animation with Bezier tracks.
  2. In the Bezier view press the Pause/Stop button while the animation is not playing.
  3. Observe that the editor jumps back to the track view.

Minimal reproduction project (MRP)

bezier_stop_issue.zip

@CookieBadger
Copy link
Contributor

@TokageItLab, I just had a look at this. I cannot find a reason for set_assigned_animation to be called, can it just be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants