Copy/Paste of TileMap from one scene to another removes TileSet from initial scene

[ysfdc]

Godot version

Godot Engine v4.1.1.stable.official.bd6af8e0e

System information

OpenGL API 4.1 Metal - 83 - Compatibility - Using Device: Apple - Apple M2

Issue description

I have tested this in 4.1, 4.1.1, and 4.1.2 and all three versions experienced the same issue. This did not happen in either 4.0 or 4.0.3.

When copying and pasting a TileMap node that has a TileSet assigned and has been laid out in the UI, from one scene to another, results in the original TileMap no longer having a TileSet and the UI shows just at atlas with some dots (see attached file).

It did not seem to matter if both scenes existed and then the process occurred. It also does not matter if you use it in the UI, although that makes it more clear that the TileSet has been removed from the TileMap node.

Steps to reproduce

1. In any of the versions noted in the description create a 2DScene
2. Add a TileMap Node
3. Add a TileSet
4. Use the TileSet in the scene
5. Create a new 2DScene
6. Copy the TileMap Node from the original scene
7. Paste into the new scene
8. Look at the original scene and see UI no longer shows what you added and if you click on the TileMap, the TileSet is no longer connected

Minimal reproduction project

N/A

[Calinou]

I have tested this in 4.1, 4.1.1, and 4.1.2 and all three versions experienced the same issue. This did not happen in either 4.0 or 4.0.3.

Can you reproduce this in 4.1 dev/beta/RC releases? You can download them here.

[bkerz]

Hey @Calinou I've tested on 4.2 beta 1 and it's still happening, here I leave a minimal reproduction project:
testing_project.zip

And also this is what the output shows after you copy paste the tilemap to another scene:

[ETHEYtheDREAMER]

I'm definitely experiencing this. It was in the middle of a Godot course where the instructor asked to copy a tilemap node in one scene and in the other scene paste it. The new scene had everything intact however the tilemap in the first scene is missing all references. It appears identical to OP's image. I repeated the instructor's steps from the beginning and got the same results. I scoured the internet/YouTube for a solution (if I'm just doing something wrong) and only found this github page.

edit: This is also on v4.1.1.stable.mono.official in Windows 11

[ysfdc]

I'm definitely experiencing this. It was in the middle of a Godot course where the instructor asked to copy a tilemap node in one scene and in the other scene paste it. The new scene had everything intact however the tilemap in the first scene is missing all references. It appears identical to OP's image. I repeated the instructor's steps from the beginning and got the same results. I scoured the internet/YouTube for a solution (if I'm just doing something wrong) and only found this github page.

edit: This is also on v4.1.1.stable.mono.official in Windows 11

Was it this video: https://youtu.be/FNEAJsry5sA?si=n932nWsCXjeiI2mT ?

[ETHEYtheDREAMER]

I'm definitely experiencing this. It was in the middle of a Godot course where the instructor asked to copy a tilemap node in one scene and in the other scene paste it. The new scene had everything intact however the tilemap in the first scene is missing all references. It appears identical to OP's image. I repeated the instructor's steps from the beginning and got the same results. I scoured the internet/YouTube for a solution (if I'm just doing something wrong) and only found this github page.
edit: This is also on v4.1.1.stable.mono.official in Windows 11

Was it this video: https://youtu.be/FNEAJsry5sA?si=n932nWsCXjeiI2mT ?

Oddly enough no, it was one from Zenva I got in a massive Godot humble bundle, specifically one for creating a basic 2D platformer using tilemaps. It's funny too because it's pretty obvious why all of a sudden there's an influx of deals for Godot courses!

The process in your tutorial is the same though and I felt really dumb for awhile until I stumbled across this. I'd REALLY love it if this bug gets fixed soon so I can finish the course.

@Calinou please let me know if you need me for anything. I used to work in UAT so hopefully I can be helpful <3

[ysfdc]

You can port your project back to 4.0.3 and it will work. That’s what I had to do to continue my tutorial. I did make a copy of the whole project first so that when the bug is fixed it can retested in the 4.1 version. Sent from my iPadOn Oct 18, 2023, at 10:55 AM, ETHER the DREAMER ***@***.***> wrote: I'm definitely experiencing this. It was in the middle of a Godot course where the instructor asked to copy a tilemap node in one scene and in the other scene paste it. The new scene had everything intact however the tilemap in the first scene is missing all references. It appears identical to OP's image. I repeated the instructor's steps from the beginning and got the same results. I scoured the internet/YouTube for a solution (if I'm just doing something wrong) and only found this github page. edit: This is also on v4.1.1.stable.mono.official in Windows 11 Was it this video: https://youtu.be/FNEAJsry5sA?si=n932nWsCXjeiI2mT ? Oddly enough no, it was one from Zenva I got in a massive Godot humble bundle, specifically one for creating a basic 2D platformer using tilemaps. It's funny too because it's pretty obvious why all of a sudden there's an influx of deals for Godot courses! @CALI The process in your tutorial is the same though and I felt really dumb for awhile until I stumbled across this. I'd REALLY love it if this bug gets fixed soon so I can finish the course. @Calinou please let me know if you need me for anything. I used to work in UAT so hopefully I can be helpful <3 —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[rakkarage]

I believe this issue only occurs for ‘internal’ tilesets that are saved in the scene. I’ve traced the problem to this section of code in the tile_set.cpp file:

DestinationTileSet::add_source calls SourceTileSet::remove_source

https://github.com/godotengine/godot/blob/e8d57afaeccf0d9f9726746f49936eb93aa0039b/scene/resources/tile_set.cpp#L484C1-L486C3

This code is part of a pull request:

#78477

After removing the deletion or only for internal tilesets (specifically, this line: if (p_tile_set_source->get_path().find("::") == -1)), it seems to work. However, the sub_resource_id of the source tileset still changes during copy, even though nothing in the source should change. If you close the source without saving (since it’s not marked as ‘dirty’), nothing happens.

This might be due to another section of code in the same file, which no longer matches its comment:

https://github.com/godotengine/godot/blob/e8d57afaeccf0d9f9726746f49936eb93aa0039b/scene/resources/tile_set.cpp#L3159C1-L3168C3

This code is also part of the same pull request. It seems like the pull request was made to handle severing ties during the ‘make local’ operation, but this function is also called when copying a tilemap between scenes.

Thanks.

[EigenLaw]

I'm definitely experiencing this. It was in the middle of a Godot course where the instructor asked to copy a tilemap node in one scene and in the other scene paste it. The new scene had everything intact however the tilemap in the first scene is missing all references. It appears identical to OP's image. I repeated the instructor's steps from the beginning and got the same results. I scoured the internet/YouTube for a solution (if I'm just doing something wrong) and only found this github page.

edit: This is also on v4.1.1.stable.mono.official in Windows 11

me too

[KilliannH]

Me too, anyone can merge the linked pull request ? I think it's a huge one

[Albaii22]

The only thing you have to do is save the tileset where your first node is and then import it into the tileset of the new node where we want to work with the same thing.

[Conga0]

Hey, I'm still having this problem occur.

It's happening in both Godot 4.1.1 and 4.2.1

https://youtu.be/agLpfY3m6mk

[KoBeWi]

The issue was fixed in Godot 4.3.