Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Particle ramp textures are set to repeat, causing visual artifacts when they restart #60032

Closed
Silvanuz opened this issue Apr 8, 2022 · 7 comments · Fixed by #60378
Closed

Comments

@Silvanuz
Copy link

Silvanuz commented Apr 8, 2022

This is my first issue report ever so I hope everything is correct.
English is not my mother tongue so please understand..

Godot 4 Alpha 6

Issue description:
So there are a few Bugs with the GPUParticles2D.
I recommend to look in the project because it's very hard to descripe the bugs.

  1. If you use a colored gradient with transparent at the end, then the particles at the end of their lifetime are suddenly displayed again in the color that is at the beginning of the gradient
  2. At the start the particles have the last Color from the gradient. This happens when you have a high amount of particles.
  3. If the FPS are set to 30 in the particles and you change the amount, there are a lot of visual glitches happening

Here is the 3. issue in my project: https://twitter.com/proj_Aetheria/status/1512212234952491014

I created an example object with all the things + A video.
Project.zip

I also have a small improvement suggestion for the gradient handling.
If you drag the slider in the gradient, for example, from the far left to the far right with the mouse and you want to undo it, then you have to press ctrl+z 1000 times because it tracks every color on the way. Maybe the retraction point should be where you started with the mouse?

Edit:

I thought of 2 new things that I had the last few days

  1. When I first add the Color Gradient to the Particle - Nothing happend. Reload the Scene fixed it. This happens everytime when I create a new Particle with Gradient
  2. I'm using an Animated Texture in the "texture" property. Sometimes in the Editor the animation doesn't work. When I run the game everything is ok. This only happens sometimes in the Editor. Fix -> Restart Godot
@Silvanuz Silvanuz added the bug label Apr 8, 2022
@clayjohn clayjohn transferred this issue from godotengine/godot-docs Apr 8, 2022
@clayjohn clayjohn added this to the 4.0 milestone Apr 8, 2022
@clayjohn
Copy link
Member

clayjohn commented Apr 8, 2022

Thanks for your bug report. I have transferred it to the main Godot repository which is where we track bug requests. You posted it on the Godot-docs page which is where we track issues with the engine documentation.

It sounds like 1 and 2 are the same root cause, the gradient texture appears to be set to "repeat" instead of being set to "clamp".

@Calinou
Copy link
Member

Calinou commented Apr 8, 2022

Related to #56691 and #56886.

@MagnusL3D-code
Copy link

This seem to happen with CurveTextures as well. Tried it on particles Scale and scaling them down over age but just before they de-spawn they'll popp back to start size.

@Calinou Calinou changed the title Several Visual Particle Bugs (?) Vulkan: Particle ramp textures are set to repeat, causing visual artifacts when they restart Apr 9, 2022
@fire-forge
Copy link
Contributor

fire-forge commented Apr 19, 2022

If you drag the slider in the gradient, for example, from the far left to the far right with the mouse and you want to undo it, then you have to press ctrl+z 1000 times because it tracks every color on the way.

I know how to fix this bug. I had this problem when making the GradientTexture2D editor. I'll add this to my to-do list and open a PR at some point 🙂

@clayjohn
Copy link
Member

@fire-forge I opened a PR right before your comment (#60378) Please review when you have the chance!

@fire-forge
Copy link
Contributor

fire-forge commented Apr 19, 2022

@clayjohn I was referring to the Gradient editor undo/redo bug. It's the quote at the top of my comment. But I will try to review your PR anyways.

@clayjohn
Copy link
Member

@fire-forge Whoops! My bad.

But I will try to review your PR anyways.

Much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants