Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Add a bounce threshold to GPUParticles to skip bouncing if the velocity is too low #57249

Open
Tracked by #61067
ghost opened this issue Jan 26, 2022 · 0 comments · May be fixed by #61245
Open
Tracked by #61067

Vulkan: Add a bounce threshold to GPUParticles to skip bouncing if the velocity is too low #57249

ghost opened this issue Jan 26, 2022 · 0 comments · May be fixed by #61245

Comments

@ghost
Copy link

ghost commented Jan 26, 2022

Godot version

v4.0.alpha.custom_build [d289448]

System information

Linux, Vulkan

Issue description

The Particles are too bouncy, even on lower bounce settings, the only way to prevent this is by making them almost not bounce, which sucks.

this only happens on lower particle framerates, like 30, it's still horrible especially when it lags.

Steps to reproduce

grab particles, make them bouncy

Minimal reproduction project

TooBouncy.zip

and a video

g.mp4

(it's actually an .avi, but gitshit doesn't upload it with .avi instead of .mp4)

Fix

make a bounce threshold that makes particles stop bouncing completely when they don't bounce much anymore

example:

some particle is .01 bouncy

make it 0 bouncy

@ghost ghost changed the title Particle Bounce threshold Particle Bounce threshold & unlock particle bounces from particle framerate Jan 26, 2022
@ghost ghost changed the title Particle Bounce threshold & unlock particle bounces from particle framerate Particle Bounce threshold Jan 26, 2022
@Chaosus Chaosus added this to the 4.0 milestone Jan 26, 2022
@Calinou Calinou changed the title Particle Bounce threshold Vulkan: Add a bounce threshold to GPUParticles to skip bouncing if the velocity is too low Jan 26, 2022
@Calinou Calinou added bug and removed enhancement labels May 21, 2022
@akien-mga akien-mga modified the milestones: 4.0, 4.1 Feb 14, 2023
@clayjohn clayjohn modified the milestones: 4.1, 4.x Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants