when enable force software skinning, the shadow will become static

[snougo]

Godot version

3.4 beta5

System information

macOS 10.14.6 intelGPU GLES3 and GLES2

Issue description

when enable force software skinning, the shadow will not update and become like static shadow, both GLES3 and GLES2, not sure is it only happen on macOS or not

in Editor

Screen.Recording.2021-09-24.at.11.48.30.PM.mov

in Runtime

Screen.Recording.2021-09-24.at.11.47.55.PM.mov

also see this

Screen.Recording.2021-09-25.at.12.18.33.AM.mov

Steps to reproduce

see Minimal reproduction project

Minimal reproduction project

TPS.zip

[snougo]

both in Editor and Runtime

[Calinou]

@snougo Can you reproduce this in 3.3.3?

[snougo]

@snougo Can you reproduce this in 3.3.3?

yes

Screen.Recording.2021-09-25.at.12.46.56.AM.mov

[lawnjelly]

At a guess it could be trying to use hardware skinning for the shadow (along with software for the main pass) and the bones aren't set. I wonder why we haven't seen this before... @pouleyKetchoupp

[pouleyKetchoupp]

It looks like shadows are just not updated because the mesh needs to be marked for update on the render side. It's done in the standard skeleton update but not in software skinning.

I'll open a PR soon.

[akien-mga]

Fixed by #53144.