Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen space reflection reflecting sky + banding (3.x) #38953

Closed
puchik opened this issue May 22, 2020 · 5 comments
Closed

Screen space reflection reflecting sky + banding (3.x) #38953

puchik opened this issue May 22, 2020 · 5 comments
Assignees
Milestone

Comments

@puchik
Copy link
Contributor

puchik commented May 22, 2020

Godot version:
3.2.2 beta 8cf450c
OS/device including version:
Windows 10 1909
Issue description:
The SSR in 3.2 currently reflects the sky which can result in banding on some angles and unnatural stretching of the sky material when starting to look down.

Banding in the reflection
image

A lot more noticeable when adding even slight roughness
image

Jarring transition from screen space to environment reflection
image

Steps to reproduce:

  1. Make a new project. Add a shiny flat surface (floor or wall).
    1.2. Optionally add an environment that makes the effect more obvious.
  2. Observe how at lower angles there's banding + if you have a sky texture set there is a jarring transition when switching from screen space to environment reflection (especially if radiance size for sky is low).

Minimal reproduction project:
ssr-sky-artifacts.zip

@Zireael07
Copy link
Contributor

A-ha, judging by the pics this should close my ancient issue with artifacts in SSR (will try to link later)

Nicely explains why I couldn't find rhyme nor reason for those, with the amount of geometry in my levels the sky would've been literally the LAST thing I would've suspected!

@puchik
Copy link
Contributor Author

puchik commented May 22, 2020

This one #18395 ?

@Zireael07
Copy link
Contributor

Yep. Forgot I already closed it thinking it a dupe of another issue.

@puchik
Copy link
Contributor Author

puchik commented May 22, 2020

Yeah there was an issue about general SSR artifacting and broken roughness but it all seems to fit under the far clip and pre-blurred mip map issues... this should hopefully at least take care of the far clip/banding one.

@akien-mga
Copy link
Member

Fixed by #38954.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants