Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting an emoji in code creates an invisible error (Parse Error: Unknown character) #25620

Closed
GuyUnger opened this issue Feb 5, 2019 · 5 comments · Fixed by #40999
Closed

Comments

@GuyUnger
Copy link

GuyUnger commented Feb 5, 2019

Godot version:
3.1 beta 3

OS/device including version:
Windows 10

Issue description:
When you paste an emoji in the code editor, it looks like it didn't accept the symbol because no character is shown. But it's there so it throws an unkown character error. It won't happen to people often but if it does happen, it could keep people clueless of what the problem is because you don't see anything wrong.

Steps to reproduce:
Paste an emoji in the code editor

@bruvzg
Copy link
Member

bruvzg commented Feb 5, 2019

Related to #23093, on Windows Godot uses 16-bit char type and does not support surrogate pairs (characters with codes > 0xFFFF won't work).

@girng
Copy link

girng commented Feb 5, 2019

i think godot is trying to tell us something

@GuyUnger
Copy link
Author

GuyUnger commented Feb 5, 2019

Yeah the code doesn't need support for emojis imo, but the code should either not accept the character at all or show a "missing symbol" symbol

@bruvzg
Copy link
Member

bruvzg commented Feb 5, 2019

or show a "missing symbol" symbol

Missing char symbol is shown in other input fields (using Noto Sans UI font) but not in the code editor (using Hack font), that's probably a problem with the font.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 23, 2020

Still valid in 05395cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants